Issue Task Closed

#102275Catch exception and return new instance of ContentObjectRenderer

TYPO3 GmbH TYPO3com 10/27/23, 14:51 updated 10/31/24, 14:48

Description

If there was no “currentContentObject” set in the request, the new instance of ContentObjectRenderer was never reached and lead to an exception

This issue was automatically created from https://github.com/TYPO3/typo3/pull/466

Reviews 1

History 24

  1. Gerrit Code Review pushed patch set 1 for 12.4 to change 81599 status New Under Review 10/27/23, 14:51

  2. Gerrit Code Review pushed patch set 2 for 12.4 to change 81599 10/27/23, 18:50

  3. Stefan Bürk commented 10/28/23, 12:14

    Mhh – `NoSuchArgumentException` is through when an “Extbase Attribute” is requestes which does not exists.

    However, requesting an attribute on the request object, even if it is a “Extbase Request” dispatches it to the PSR-7 event.

    Without further information I would say, that a overriden “Extbase Request” from old times by custom or 3rd party extension is passed in, not reflect the changes done for TYPO3 v12 on the extbase request stuff.

    Therefore, this is an issue of the not aligned xclassed/extended extbase request. That should properly avoid the extbase attribute retrival with getAttribute() and adopt the getExtbaseAttribute() instead.

    This is comapt code, and hiding the issue of 3rd party code not aligned to TYPO3 v12 code is the charge of the code extending it.

    I do not see the core in charge to add a additional try {} here not possible with pure core usage. The extending extension need to fix this, not the core.

  4. Benni Mack commented and changed status Under Review Closed 10/31/24, 14:48

    Closing this one due to lack of feedback here.