Issue Bug Closed

#102751AbstractUserAuthentication: Missing condition for empty checkPid_value

Sven Proffe 01/04/24, 12:48 updated 07/09/24, 15:12

Description

In TYPO3\CMS\Core\Authentication\AbstractUserAuthentication, line 919 reads (as of current main):

if ($this->checkPid && $this->checkPid_value !== null) {

As $this->checkPid_value may be a string it may be empty, which is not checked. In that case TYPO3\CMS\Core\Authentication\AbstractAuthenticationService->fetchUserRecord() will end up with a corrupt SQL query containing a restriction like … AND pid in ()…

So, I’d like to suggest to check for an empty string, as well.

if ($this->checkPid && $this->checkPid_value !== null && $this->checkPid_value !== '') {

Reviews 2

History 37

  1. Sven Proffe changed description 01/04/24, 12:50

  2. Gerrit Code Review pushed patch set 1 for main to change 82309 status New Under Review 01/04/24, 13:33

  3. Gerrit Code Review pushed patch set 2 for main to change 82309 01/04/24, 14:04

  4. Gerrit Code Review pushed patch set 3 for main to change 82309 01/04/24, 14:14

  5. Gerrit Code Review pushed patch set 1 for 12.4 to change 82372 01/05/24, 08:05

  6. Oliver Bartsch commented and changed status Under Review Resolved done 0 % 100 % 01/05/24, 08:20

    Applied in changeset commit:db53130a16aef18f572386c3ce66e0bf7026683e.

  7. Benni Mack changed status Resolved Closed 07/09/24, 15:12