Issue Bug Closed

#103007Outdated PHPdoc comment for logicalAnd() and logicalOr()

Albrecht Köhnlein 01/31/24, 19:20 updated 07/09/24, 15:12

Description

The comment says “… the two given constraints …” while in fact, any number is allowed

    /**
     * Performs a logical conjunction of the two given constraints. The method
     * takes an arbitrary number of constraints and concatenates them with a boolean AND.
     */
    public function logicalAnd(ConstraintInterface ...$constraints): AndInterface;

    /**
     * Performs a logical disjunction of the two given constraints. The method
     * takes an arbitrary number of constraints and concatenates them with a boolean OR.
     */
    public function logicalOr(ConstraintInterface ...$constraints): OrInterface;

Reviews 2

History 36

  1. Gerrit Code Review pushed patch set 1 for main to change 82753 status New Under Review 01/31/24, 19:21

  2. Albrecht Köhnlein changed description 01/31/24, 19:25

  3. Gerrit Code Review pushed patch set 2 for main to change 82753 02/02/24, 14:39

  4. Gerrit Code Review pushed patch set 1 for 12.4 to change 82739 02/02/24, 16:14

  5. Albrecht Köhnlein commented and changed status Under Review Resolved done 0 % 100 % 02/02/24, 16:25

    Applied in changeset commit:3b068da5bdf8c52ddda4181a294df9ffb03cd04b.

  6. Benni Mack changed status Resolved Closed 07/09/24, 15:12