#103149CSP prevents sitemap.xml inline CSS styles
Description
Problem/Description
CSS Inline Styles in the auto generated sitemap.xml feature is blocked by Content Security Policy per default.
Affected: main, 13.0, 12.4
Acceptance Criteria
The styles should work without modifying CSP rules or the sitemap.xml template files.
—-
BTW: what about a dedicated redmine category named “Content Security Policy”?
Reviews 3
Related issues 3
Files 1
History 1333
Show 78 earlier messages
-
Benni Mack changed category <span data-processor="relativetime" data-value="2024-03-29T19:34:24+00:00" > 03/29/24, 19:34 </span>
-
Timo Webler changed Related to #103567 <span data-processor="relativetime" data-value="2024-04-09T06:13:39+00:00" > 04/09/24, 06:13 </span>
-
Oliver Hader commented and changed status
NewUnder Review <span data-processor="relativetime" data-value="2024-04-29T07:20:39+00:00" > 04/29/24, 07:20 </span>- How to reproduce?
- What are the CSP headers being sent?
- What are the CSP violations being issued?
Besides that: Is it really relevant, that
sitemap.xmlsupports styles when being shown in a browser? Or is it more like it should skip reports forsitemap.xmlin case something is wrong there (but still block styles)? -
Timo Webler commented and changed attached clipboard-202404290938-exdlf.png <span data-processor="relativetime" data-value="2024-04-29T07:38:31+00:00" > 04/29/24, 07:38 </span>
Oliver Hader wrote in #note-4:
> * How to reproduce?csp.yaml:# Inherits default site-unspecific frontend policy mutations (enabled per default) inheritDefault: true mutations: - mode: set directive: 'default-src' sources: ["'none'"] - mode: set directive: 'manifest-src' sources: ["'self'"] - mode: set directive: 'img-src' sources: ["'self'", "data:"] - mode: set directive: 'style-src' sources: ["'self'", "'unsafe-inline'"] - mode: set directive: 'base-uri' sources: ["'self'"] - mode: set directive: 'form-action' sources: ["'self'"] - mode: set directive: 'media-src' sources: ["'self'"] - mode: set directive: 'connect-src' sources: ['self'] - mode: set directive: 'script-src' sources: ["'nonce-proxy'", "'self'"]> * What are the CSP headers being sent?
Content-Security-Policy: default-src 'none'; script-src 'nonce-JkAMWyZSCu6GhrHfwK6WLSPUIQC0vgunGZEmd-9RT1PpSpowF0zRfA' 'self' 'report-sample'; style-src-attr 'unsafe-inline' 'report-sample'; img-src 'self' data:; base-uri 'self'; frame-src 'self' *.youtube-nocookie.com *.youtube.com *.vimeo.com; style-src-elem 'self' 'nonce-JkAMWyZSCu6GhrHfwK6WLSPUIQC0vgunGZEmd-9RT1PpSpowF0zRfA' 'report-sample'; manifest-src 'self'; style-src 'self' 'unsafe-inline' 'report-sample'; form-action 'self'; media-src 'self'; connect-src self; report-uri https://exmaple.com
> * What are the CSP violations being issued?
clipboard-202404290938-exdlf.png
> Besides that: Is it really relevant, that
sitemap.xmlsupports styles when being shown in a browser? Or is it more like it should skip reports forsitemap.xmlin case something is wrong there (but still block styles)?Not really relevant. But TYPO3 deliver a stylesheet for that view and than it should work. Maybe remove the stylesheets for sitemap.xml as alternative solution.
-
Oliver Hader commented <span data-processor="relativetime" data-value="2024-04-30T20:01:42+00:00" > 04/30/24, 20:01 </span>
Thanks for the feedback, I was able to reproduce the behavior…
The resulting CSP violation looks like this:
{ "document-uri": "https://ip13.anyhost.it/?type=1533906435", "referrer": "", "violated-directive": "style-src-elem", "effective-directive": "style-src-elem", "original-policy": "default-src 'self'; script-src 'self' 'nonce-wdB5XPhMdnxXxfNpAsJGflt5UH0o_5-Z4ijHDwQLoQ-03gInUmWx_w' 'report-sample'; style-src-attr 'unsafe-inline' 'report-sample'; img-src 'self' data: *.ytimg.com *.vimeocdn.com; base-uri 'self'; frame-src 'self' *.youtube-nocookie.com *.youtube.com *.vimeo.com; style-src-elem 'self' 'nonce-wdB5XPhMdnxXxfNpAsJGflt5UH0o_5-Z4ijHDwQLoQ-03gInUmWx_w' 'report-sample'; report-uri https://ip13.anyhost.it/@http-reporting?csp=report&requestTime=1714503719476538", "disposition": "enforce", "blocked-uri": "inline", "line-number": 2, "source-file": "https://ip13.anyhost.it/", "status-code": 200, "script-sample": "body {\n font-fami" }script-samplegives an indication of what exactly caused the violation. -
Gerrit Code Review pushed patch set 1 for main to change 84099 <span data-processor="relativetime" data-value="2024-04-30T20:10:26+00:00" > 04/30/24, 20:10 </span>
-
Oliver Hader changed Related to #100887 <span data-processor="relativetime" data-value="2024-04-30T20:10:53+00:00" > 04/30/24, 20:10 </span>
-
Oliver Hader commented <span data-processor="relativetime" data-value="2024-04-30T20:13:06+00:00" > 04/30/24, 20:13 </span>
The patch at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84099 is providing those hashes for the XSLT styles.
The hash value might be applied statically as well (
sha256-d0ax6zoVJBeBpy4l3O2FJ6Y1L4SalCWw2x62uoJH15k=) – but I think this might be forgotten, in case the styles would be adjusted (even changing the formatting, whitespaces, etc. would require a new hash to be generated). -
Gerrit Code Review pushed patch set 2 for main to change 84099 <span data-processor="relativetime" data-value="2024-04-30T20:34:51+00:00" > 04/30/24, 20:34 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 84099 <span data-processor="relativetime" data-value="2024-05-02T21:01:00+00:00" > 05/02/24, 21:01 </span>
-
Peter Kraume changed Duplicated by #104125 <span data-processor="relativetime" data-value="2024-06-18T15:39:57+00:00" > 06/18/24, 15:39 </span>
-
Garvin Hicking commented <span data-processor="relativetime" data-value="2024-06-18T18:29:36+00:00" > 06/18/24, 18:29 </span>
From dupe report #104125 a suggestion:
“Maybe by adding a check if CSP is off in the frontend and only then inserting the xsl?”
which has also been voiced here. The current patch seems to have stalled due to caching / performance implications.
Personally I do also think the stylesheet isn’t that important to have, and we could just drop it when frontend CSP feature is active, instead of doing all this dynamic processing…?
-
Gerrit Code Review pushed patch set 4 for main to change 84099 <span data-processor="relativetime" data-value="2024-07-01T07:54:14+00:00" > 07/01/24, 07:54 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 84099 <span data-processor="relativetime" data-value="2024-07-01T08:27:18+00:00" > 07/01/24, 08:27 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 84099 <span data-processor="relativetime" data-value="2024-07-02T18:03:49+00:00" > 07/02/24, 18:03 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 84099 <span data-processor="relativetime" data-value="2024-07-02T18:05:38+00:00" > 07/02/24, 18:05 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 84099 <span data-processor="relativetime" data-value="2024-07-03T12:04:55+00:00" > 07/03/24, 12:04 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 84099 <span data-processor="relativetime" data-value="2024-09-03T08:31:06+00:00" > 09/03/24, 08:31 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-05T10:44:30+00:00" > 10/05/24, 10:44 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-05T11:19:19+00:00" > 10/05/24, 11:19 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-11T16:40:36+00:00" > 10/11/24, 16:40 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-18T13:54:40+00:00" > 10/18/24, 13:54 </span>
-
Gerrit Code Review pushed patch set 14 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-22T06:57:32+00:00" > 10/22/24, 06:57 </span>
-
Gerrit Code Review pushed patch set 15 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-22T07:29:50+00:00" > 10/22/24, 07:29 </span>
-
Gerrit Code Review pushed patch set 16 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-22T16:18:52+00:00" > 10/22/24, 16:18 </span>
-
Gerrit Code Review pushed patch set 17 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-28T21:47:45+00:00" > 10/28/24, 21:47 </span>
-
Gerrit Code Review pushed patch set 18 for main to change 84099 <span data-processor="relativetime" data-value="2024-10-28T22:23:12+00:00" > 10/28/24, 22:23 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 86824 <span data-processor="relativetime" data-value="2024-10-29T12:56:27+00:00" > 10/29/24, 12:56 </span>
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 86825 <span data-processor="relativetime" data-value="2024-10-29T13:19:53+00:00" > 10/29/24, 13:19 </span>
-
Oliver Hader commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2024-10-29T13:30:08+00:00" > 10/29/24, 13:30 </span>Applied in changeset commit:937fbfe1365632c9965550fea0c33eb396bea106.
-
Georg Ringer changed Related to #106561 <span data-processor="relativetime" data-value="2025-04-11T20:14:51+00:00" > 04/11/25, 20:14 </span>
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:33:20+00:00" > 12/02/25, 14:33 </span>
Our current workaround: