Issue Task Closed

#103277Throw LogicException in HashService

Torben Hansen 03/04/24, 20:30 updated 07/09/24, 15:33

Description

The HashService class throws a custom EmptyAdditionalSecretException, when the $additionalSecret parameter is an empty string. The custom exception does however not suit well in this case, since the exception is caused by a developer not respecting the functions parameter requirements and the exception should not be catched. The custom exception should therefore be removed and a top level exception thrown instead.

Reviews 1

History 23

  1. Gerrit Code Review pushed patch set 1 for main to change 83206 status New Under Review 03/04/24, 20:37

  2. Torben Hansen commented and changed status Under Review Resolved done 0 % 100 % 03/04/24, 22:05

    Applied in changeset commit:a13c66aeb1f90734a3336603f5332ed98521eec0.

  3. Benni Mack changed status Resolved Closed 07/09/24, 15:33