#103480Inline relations: "New button" shown even when "maxitems" is exceeded
Description
Context
The introduction of the new TCA type “file” brought several refactorings.
During the refactorings, the following line of code was removed:
$config['inline']['inlineNewRelationButtonStyle'] = 'display: none;';
Issue
Now, when using inline relations, the maxitems value is not considered when showing the button. It is now always shown, even when no new records can be added.
Considering this example:
$GLOBALS['TCA']['tt_content']['columns']['myext_field'] = [
'label' => 'Test',
'config' => [
'type' => 'inline',
'maxitems' => 2,
'foreign_table' => 'myext_table',
'foreign_table_field' => 'tablenames',
'foreign_field' => 'uid_foreign',
'foreign_label' => 'uid_local',
'foreign_match_fields' => [
'fieldname' => 'myext_field'
],
'foreign_selector' => 'uid_local',
'foreign_sortby' => 'sorting_foreign',
]
];
Defining foreign_selector will render the relations view and make the records selectable via the relation wizard.
The “Add relation” button however is no longer hidden, when “maxitems” is reached. This is only the case for the non-relation way.
Suggested Fix
Restoring line 282.
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
Files 1
History 2
-
Georg Ringer commented and changed status
NewNeeds Feedback 06/08/24, 08:44 -
Oliver Hader commented and changed status
Needs FeedbackClosed 01/23/25, 11:47I also did not manage to reproduce this with recent v13.4.4 with
tt_content.imageand havingmaxitems => 1.I’m closing this issue. Feel free to reopen the issue, providing additional details how to reproduce the behavior (your TCA configuration, exact TYPO3 version). Thx!
I can’t reproduce it with e.g. modifying EXT:news
'related_links' => [ 'exclude' => true, 'label' => $ll . 'tx_news_domain_model_news.related_links', 'config' => [ 'type' => 'inline', 'allowed' => 'tx_news_domain_model_link', 'foreign_table' => 'tx_news_domain_model_link', 'foreign_sortby' => 'sorting', 'foreign_field' => 'parent', 'size' => 5, 'minitems' => 0, 'maxitems' => 2, 'appearance' => [ 'collapseAll' => true, 'expandSingle' => true, 'levelLinksPosition' => 'bottom', 'useSortable' => true, 'showPossibleLocalizationRecords' => true, 'showAllLocalizationLink' => true, 'showSynchronizationLink' => true, 'enabledControls' => [ 'info' => false, ], ], 'behaviour' => [ 'allowLanguageSynchronization' => true, ], ], ],can you retest in latest versions