Issue Task Closed

#103499ckeditor 5 - Add parameter explanation/description

wini2 no-lastname-given 03/28/24, 15:13 updated 10/15/24, 09:31

Description

ckeditor5 presets contain configurations like (Full.yaml)
- { name: ‘Yellow marker’, element: ‘span’, classes: [], styles: { background-color: ‘yellow’ } }
but styles does nothing at all. A yellow marker appears in the dropdown only if a class is defined, so the conculsion seems that styles is superfluous (maybe a leftover form ckeditor4). If I’m wrong, please add an explanation in the docs.

Reviews 2

History 412

  1. Chris Müller changed category 03/28/24, 17:04

  2. Gerrit Code Review pushed patch set 3 for main to change 84679 status New Under Review 07/16/24, 15:38

  3. Garvin Hicking commented 07/16/24, 15:40

    The configuration in this part is not specific to TYPO3, so CKEditor5 dictates this:

    https://ckeditor.com/docs/ckeditor5/latest/api/module_style_styleconfig-StyleDefinition.html

    Sadly I haven’t found a migration guide for this in the CKEditor (https://ckeditor.com/docs/ckeditor5/latest/updating/migration-from-cke4.html).

    However, the TYPO3 Changelog contains a note about it:

    https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Feature-96874-CKEditor5.html#configuration-options

    In this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679 I’m now also removing this invalid “styles:” syntax from the definition. Sadly this kind of makes a “yellow marker” invalid, because it’s only controlled via the CSS class, and one has to implement such a CSS class in their own frontend and CKEditor CSS definitions…

  4. Gerrit Code Review pushed patch set 4 for main to change 84679 07/31/24, 08:08

  5. Gerrit Code Review pushed patch set 5 for main to change 84679 08/02/24, 13:18

  6. Gerrit Code Review pushed patch set 6 for main to change 84679 08/22/24, 23:05

  7. Gerrit Code Review pushed patch set 7 for main to change 84679 08/22/24, 23:12

  8. Gerrit Code Review pushed patch set 8 for main to change 84679 08/29/24, 07:32

  9. Gerrit Code Review pushed patch set 9 for main to change 84679 08/29/24, 08:26

  10. Gerrit Code Review pushed patch set 1 for 12.4 to change 85766 08/29/24, 09:57

  11. Garvin Hicking commented and changed status Under Review Resolved done 0 % 100 % 08/29/24, 10:00

    Applied in changeset commit:1ab46cb3aed8e40c09eb19f7a11720567589c7b1.

  12. Benni Mack changed status Resolved Closed 10/15/24, 09:31