Issue Task Closed

#103605Enable corrected test for default value parsing

Stefan Bürk 04/11/24, 11:41 updated 07/09/24, 15:37

Description

Test covering the SQL file parser has been streamlined
and enriched with #103602, adding a disabled test with
a todo to enable it with the corresponding bugfix.

Mentally missleaded, the disabled test itself is not
correct based on the fact that MySQL and MariaDB use
single quotes to quote single quotes in values like

DEFAULT ‘some value with a ‘’ (single quote)’

instead of the assumed `\’` variant.

Further studies revealed that the prehistoric parser
is more than capable to properly parse this form of
default values.

Reviews 2

History 37

  1. Gerrit Code Review pushed patch set 1 for main to change 83746 status New Under Review 04/11/24, 11:43

  2. Stefan Bürk changed Related to #103602 04/11/24, 11:44

  3. Gerrit Code Review pushed patch set 2 for main to change 83746 04/11/24, 15:11

  4. Gerrit Code Review pushed patch set 1 for 12.4 to change 83754 04/11/24, 18:32

  5. Gerrit Code Review pushed patch set 2 for 12.4 to change 83754 04/11/24, 18:33

  6. Stefan Bürk commented and changed status Under Review Resolved done 0 % 100 % 04/11/24, 18:35

    Applied in changeset commit:8fd523045b5f7f81cd4d0c6642f4ed0e732dbbdd.

  7. Benni Mack changed status Resolved Closed 07/09/24, 15:37