Issue Task Closed

#103926Avoid implicitly nullable parameter on DatabaseRecordException

Stefan Bürk 05/26/24, 20:22 updated 07/09/24, 15:35

Description

With PHP 8.4 marking method parameter implicitly nullable
is depreacted and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

In cases, where are implicitly nullable parameter exists
before not-nullable parameters in a method or constructor,
making it explicitly nullable will emit a

Optional parameter <paramname> declared before required
parameter <paramname> is implicitly treated as a required
parameter

since PHP 8.0 [2].

This change modifies the class constructor signature of
`\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException`
and moves the required parameter before the optional and
nullable previous execption parameter and adjust the
core place throwing this exception to follow that pattern.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
2 https://php.watch/versions/8.0/deprecate-required-param-after-optional

Reviews 3

History 39

  1. Stefan Bürk changed tracker Bug Task 05/26/24, 20:24

  2. Gerrit Code Review pushed patch set 1 for main to change 84415 status New Under Review 05/26/24, 20:24

  3. Gerrit Code Review pushed patch set 2 for main to change 84415 05/26/24, 20:28

  4. Gerrit Code Review pushed patch set 3 for main to change 84415 05/27/24, 10:36

  5. Gerrit Code Review pushed patch set 4 for main to change 84415 05/27/24, 12:06

  6. Gerrit Code Review pushed patch set 1 for 12.4 to change 84360 05/27/24, 12:11

  7. Gerrit Code Review pushed patch set 1 for 11.5 to change 84361 05/27/24, 12:12

  8. Stefan Bürk commented and changed status Under Review Resolved done 0 % 100 % 05/27/24, 12:25

    Applied in changeset commit:577864d14a26ea9914db7c8efba48170b43e594d.

  9. Benni Mack changed status Resolved Closed 07/09/24, 15:35