Issue Bug Closed

#103972"this.createRenderRoot is not a function" JavaScript error for the image focusArea with Firefox

Tobias Gülzow 06/04/24, 08:41 updated 12/02/25, 14:33

Description

Hi everyone.

When using Firefox in the backend, and when you try to edit an Image with a focusArea, you get several JS errors:
  1. Uncaught TypeError: this.createRenderRoot is not a function
  2. Uncaught TypeError: this.pointerEventNames is undefined
  3. Uncaught TypeError: this.createRenderRoot is not a function
How to reproduce:
  1. Setup a new TYPO3 12 lts (composer or classic)
  2. Install Firefox browser (it works fine in Chrome)
  3. Install the introduction package
  4. Add the tsConfig (see below) to the root page
  5. Go to the backend with the firefox bowser
  6. Add a new image element somewhere on any page
  7. Add an image to the element
  8. Open the image in the image editor

The focusArea does not render, and you get the JS error from above.

The used tsConfig:

TCEFORM.sys_file_reference.crop.config.cropVariants {
    default {
        title = Default
        selectedRatio = NaN
        focusArea {
            x = 0.45
            y = 0.45
            width = 0.1
            height = 0.1
        }
    }
}

See also : #103048

Tobi

Reviews 6

Files 1

History 1524

  1. Garvin Hicking commented and changed status New Needs Feedback <span data-processor="relativetime" data-value="2024-06-04T10:40:07+00:00" > 06/04/24, 10:40 </span>

    Could you mention with which OS and Firefox version you tested this?

    Are any other custom extensions involved or maybe Firefox plugins? The mentioned javascript methods are part of the shadow DOM operation, and I can’t reproduce it here (MacOS 14.5, FF 126.0.1) with the steps you outlined, it works here

  2. Tobias Gülzow commented <span data-processor="relativetime" data-value="2024-06-04T10:48:34+00:00" > 06/04/24, 10:48 </span>

    OS Version: Microsoft Windows 11 Pro
    Patchlevel: 10.0.22631
    Firefox version: 126.0.1
    Firefox Plugins: None (I just switched them all off, tested again and got the same result).

  3. Andreas Kienast commented <span data-processor="relativetime" data-value="2024-06-04T10:58:27+00:00" > 06/04/24, 10:58 </span>

    I can at least reproduce the Uncaught TypeError: this.createRenderRoot is not a function error. For whatever reason, Firefox only displayed the first error. I can now reproduce all of them.

  4. Andreas Kokott commented <span data-processor="relativetime" data-value="2024-06-04T11:09:46+00:00" > 06/04/24, 11:09 </span>

    I can confirm this issue on Firefox 126.0.1 (64-bit) on MacOs in a Typo3 12.4.15 installation

    Uncaught TypeError: this.pointerEventNames is undefined
        disconnectedCallback ..typo3/sysext/backend/Resources/Public/JavaScript/element/draggable-resizable-element.js:13
        update ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        init ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        init ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        init ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        initializeCropperModal ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        show ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        promise callback*show/</< ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        show ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        trigger ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:53
        render ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:20
        handleEvent ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js:6
        trigger ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        _showElement ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Ut ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        o ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Gt ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        _queueCallback ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        _showElement ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        show ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Ut ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        show ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Ut ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        o ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Gt ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        _emulateAnimation ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        show ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        show ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        firstUpdated ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:13
        _$AE ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        performUpdate ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        scheduleUpdate ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        _$ET ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        requestUpdate ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        _$Ev ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        b ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        s ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js:6
        ModalElement ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:13
        generate ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:53
        advanced ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:53
        show ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        triggerListener ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        delegateTo ..typo3/sysext/core/Resources/Public/JavaScript/event/regular-event.js:13
    draggable-resizable-element.js:13:2242
    Uncaught TypeError: this.createRenderRoot is not a function
        connectedCallback ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        connectedCallback ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js:6
        connectedCallback ..typo3/sysext/backend/Resources/Public/JavaScript/element/draggable-resizable-element.js:13
        initFocusArea ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        update ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        init ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        init ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        init ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        initializeCropperModal ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        show ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        promise callback*show/</< ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        show ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        trigger ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:53
        render ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:20
        handleEvent ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js:6
        trigger ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        _showElement ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Ut ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        o ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Gt ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        _queueCallback ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        _showElement ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        show ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Ut ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        show ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Ut ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        o ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        Gt ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        _emulateAnimation ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        show ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        show ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js:7
        firstUpdated ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:13
        _$AE ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        performUpdate ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        scheduleUpdate ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        _$ET ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        requestUpdate ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        _$Ev ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        b ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js:6
        s ..typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js:6
        ModalElement ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:13
        generate ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:53
        advanced ..typo3/sysext/backend/Resources/Public/JavaScript/modal.js:53
        show ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        triggerListener ..typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js:13
        delegateTo ..typo3/sysext/core/Resources/Public/JavaScript/event/regular-event.js:13
    reactive-element.js:6:3154
  5. Garvin Hicking commented and changed status Needs Feedback Accepted <span data-processor="relativetime" data-value="2024-06-04T11:14:49+00:00" > 06/04/24, 11:14 </span>

    ACK, thanks for the confirmation.

    In fact I see the errors now too, my Inspector console was set to a filtered state (and it seems functionally it all works, I can still crop a file)

  6. Andreas Kokott commented <span data-processor="relativetime" data-value="2024-06-04T11:19:38+00:00" > 06/04/24, 11:19 </span>

    Garvin Hicking wrote in #note-5:
    > ACK, thanks for the confirmation.
    >
    > In fact I see the errors now too, my Inspector console was set to a filtered state (and it seems functionally it all works, I can still crop a file)

    but the configured focus area isnt visible

  7. Garvin Hicking commented and changed attached Screenshot 2024-06-25 at 13.00.24.png <span data-processor="relativetime" data-value="2024-06-25T11:09:46+00:00" > 06/25/24, 11:09 </span>

    The focusArea bug is reproducible for me in v13 main with Firefox 127, too. See screenshot.

    This seems to originate from Build/Sources/TypeScript/backend/image-manipulation.ts method initFocusArea() – somehow the web component is not converted in FireFox due to some ShadowDOM operation?

  8. Thomas Sam Wittich commented <span data-processor="relativetime" data-value="2024-12-08T19:25:55+00:00" > 12/08/24, 19:25 </span>

    Before i found this bug here, i entered it as well her:
    https://forge.typo3.org/issues/105791
    In this bug a little video is available how it looks like. (Can’t close it myself as duplicate, sorry)
    Also, i could see the same Firefox console messages and verify that it’s working in Chrome.

    Thank you!

  9. Thomas Sam Wittich commented <span data-processor="relativetime" data-value="2025-03-31T09:06:29+00:00" > 03/31/25, 09:06 </span>

    Thomas Sam Wittich wrote in #note-9:
    > Before i found this bug here, i entered it as well her:
    > https://forge.typo3.org/issues/105791
    > In this bug a little video is available how it looks like. (Can’t close it myself as duplicate, sorry)
    > Also, i could see the same Firefox console messages and verify that it’s working in Chrome.
    >
    > Thank you!

    Dear Garvin,

    i still constantly fall into this pit. (Working with FF mainly).

    I guess, it’s more than just a “should have” – since the focus-area-feature comes more and more in place (at least with my TYPO3-integrations).

    You provided already a patch: https://forge.typo3.org/issues/101800

    Is it / was it going to the latest TYPO3 v12 and v13 releases, means, the bug is solved already?
    (i use 12.4.27 now and did not see a mentioning of this bugfix / patch in der release notes of 12.4.28)

    Garvin, any clue about how the next steps to solve it would be wonderful.
    Can i do something for it?

    Thank you, Thomas

  10. Garvin Hicking commented <span data-processor="relativetime" data-value="2025-03-31T13:08:44+00:00" > 03/31/25, 13:08 </span>

    Hi,

    Sadly my own JS skills are insufficient to solve this issue.

    The patch you linked as abandoned with a “not working” remark, so I was just guessing there were problems, but not which.

    So: there currently is no patch approved or pending which addresses the issue.

    I will kindly ask the most skilled JS developer I know in our team if he see’s a way forward with this. 🤞🏻

  11. Gerrit Code Review pushed patch set 1 for main to change 89140 status Accepted Under Review <span data-processor="relativetime" data-value="2025-04-16T11:16:42+00:00" > 04/16/25, 11:16 </span>

  12. Anonymous commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2025-04-28T07:45:10+00:00" > 04/28/25, 07:45 </span>

    Applied in changeset commit:d10ec37e23e0c5853d777da9d69f5785159e969d.