Issue Bug Closed

#104066Remove invalid intendation style inside SiteConfiguration Overview

Michael Telgkamp 06/12/24, 09:26 updated 07/09/24, 15:37

Description

No description.

Reviews 2

Files 1

History 69

  1. Gerrit Code Review pushed patch set 1 for main to change 84671 status In Progress Under Review 06/12/24, 19:30

  2. Michael Telgkamp commented 06/12/24, 19:32

    In the `for` loop the variable `rootPage` is set, but outside the loop `rootLinePage` is used for the style definition.

  3. Christian Kuhn changed attached Screenshot from 2024-06-12 22-04-04.png 06/12/24, 20:04

  4. Christian Kuhn commented 06/12/24, 20:04

    is this nesting intended?

  5. Gerrit Code Review pushed patch set 2 for main to change 84671 06/12/24, 20:29

  6. Michael Telgkamp commented and changed subject Wrong variable name used in inline style inside SiteConfiguration Overview Remove invalid intendation style inside SiteConfiguration Overview 06/12/24, 20:31

    Remove the inline style completely as it was not used since 12.3
    Additionally the margin computation can be removed.

  7. Gerrit Code Review pushed patch set 1 for 12.4 to change 84635 06/12/24, 20:43

  8. Michael Telgkamp commented and changed status Under Review Resolved done 0 % 100 % 06/12/24, 20:50

    Applied in changeset commit:0bac4e75db35b313cbe0ab92a7ce916bce8065ab.

  9. Benni Mack changed status Resolved Closed 07/09/24, 15:37