Issue Bug Closed

#104171Make context menu fire 'click' on keyboard spacebar press

Ayke Halder 06/21/24, 08:16 updated 12/02/25, 14:33

Description

The context-menu does not fire ‘click’ on spacebar press.

Technical background

  • event.key for spacebar is ‘@ ' (blank) * event.code@ for spacebar is ‘@Space@’

https://www.toptal.com/developers/keycode/space

/* current implementation */
switch (event.key) {
  case 'Enter':
  case 'Space':
    target.click();
    break;
}

/* must become */
switch (event.key) {
  case 'Enter':
  case ' ':
    target.click();
    break;
}

Reviews 2

History 616

  1. Riccardo De Contardi changed Tags UX,Accessibility UX accessibility <span data-processor="relativetime" data-value="2024-06-27T09:24:25+00:00" > 06/27/24, 09:24 </span>

  2. Riccardo De Contardi changed Tags UX accessibility UX, accessibility <span data-processor="relativetime" data-value="2024-06-27T09:30:02+00:00" > 06/27/24, 09:30 </span>

  3. Riccardo De Contardi changed Complexity easy Sprint Focus On Location Sprint <span data-processor="relativetime" data-value="2024-07-01T10:18:02+00:00" > 07/01/24, 10:18 </span>

  4. Gerrit Code Review pushed patch set 13 for main to change 87887 status New Under Review <span data-processor="relativetime" data-value="2025-02-03T13:30:56+00:00" > 02/03/25, 13:30 </span>

  5. Benjamin Kott commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2025-02-05T08:00:09+00:00" > 02/05/25, 08:00 </span>

    Applied in changeset commit:1ba69b73e98543ff1b6a4635cc9781878e279424.