#104191A call to TYPO3\CMS\Core\Page\AssetCollector->addStyleSheet() is interpreted incorrectly
Description
$assetCollector->addStyleSheet() triggers the following issues in “Scan Extension Files”:
- Deprecation: #85735 – Various method and property in DocumentTemplate
- Breaking: #87193 – Deprecated functionality removed
This seems to be wrong, because TYPO3\CMS\Core\Page\AssetCollector->addStyleSheet() is not related to TYPO3\CMS\Backend\Template\DocumentTemplate->addStyleSheet() .
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
History 5
-
Christian Kuhn commented 06/24/24, 11:38
-
Stephan Kellermayr commented 06/24/24, 11:41
Thanks Christian, that’s OK for me, I can live with it. I’m just wondering whether it will be so obvious to others who use my extension …?
Christian Kuhn wrote in #note-1:
> I tend to reject the issue. I that ok with you? -
Stephan Kellermayr commented 06/24/24, 11:45
Ah, I just saw that there is an option
extensionScannerIgnoreFile@ that I can use to prevent this (which seems legitimate in this case, since it is actually a false positive). -
Christian Kuhn changed status
NewRejected 06/24/24, 11:48 -
Christian Kuhn commented 06/24/24, 11:48
Cool. Thanks for quick feedback!
False positives are part of the nature of the extension scanner, as explained here:
https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/HowTo/UpdateExtensions/ExtensionScanner.html
Non-static matches are thus always marked as “weak” matches.
In this case, I’d say it’s ok to keep that matcher entry (the option is to remove it).
I tend to reject the issue. I that ok with you?