Issue Bug Closed

#104222TypoScript import do not recognize historical file names

Thorben Nissen 06/26/24, 13:43 updated 06/27/24, 14:17

Description

The new TypoScript parser does not recognize historical TypoScript files names like `constants.txt`, `setup.txt` or `*.ts` during processing of the `@import` directives.

As these filenames and extensions are still supported in some parts of the application, the `@import` directives should recognize them too.

Reviews 1

History 47

  1. Georg Ringer changed Sprint Focus Needs Decision 06/26/24, 15:43

  2. Garvin Hicking commented and changed status New Needs Feedback 06/26/24, 18:35

    I think the intent here is to rather drop the old file formats everywhere and go forward with the new file extensions everywhere.

    Where does the old syntax still work that you refer to?

  3. Thorben Nissen commented 06/27/24, 07:29

    @ghi Both the static file include from `sys_template` and the old `<include_typoscript>` syntax allow for including `setup.txt` files.</include_typoscript>

    I agree, that it would be a good idea to remove the old `<include_typoscript>` syntax and old `.txt` file extensions. I guess that must be deprecated first with v14 and then removed in v15, meaning we would have v12, v13 and v14 which still supports the old syntax and therefore the `@import` should support it too.</include_typoscript>

  4. Gerrit Code Review pushed patch set 1 for main to change 84939 status Needs Feedback Under Review 06/27/24, 07:47

  5. Gerrit Code Review pushed patch set 2 for main to change 84939 06/27/24, 07:54

  6. Gerrit Code Review pushed patch set 3 for main to change 84939 06/27/24, 07:55

  7. Garvin Hicking commented and changed status Under Review Closed 06/27/24, 14:17

    Thank you for the feedback and also the work you put into deliver a patch for it, much appreciated.

    The feedback in the patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/84939 is rather specific and I believe this change will not find its way into the Core at this time. I hope it’s ok with you to thus close this issue for the time being.

    If the discussion in the patch itself goes into a different direction, this issue will automatically be set to ‘resolved’ though :-)