#104345Composer installation of a Root Package does not properly store packagePath
Description
The created PackageArtifact.php file currently stores “//” as packagePath for the composer root package. This path makes further usage buggy, for example with JavascriptModules resolvign the path “//” improperly.
Caused by https://review.typo3.org/c/Packages/TYPO3.CMS/+/84383 due to the removal of “handleRootPackage” in the loop of extensions.
Can be reproduced with any TYPO3 extension installation like https://github.com/eliashaeussler/typo3-warming
Happes in v12 and v13
Reviews 2
Related issues 1
History 48
-
Garvin Hicking changed Related to #103898 07/10/24, 08:00
-
Gerrit Code Review pushed patch set 1 for main to change 85212 status
AcceptedUnder Review 07/10/24, 08:04 -
Gerrit Code Review pushed patch set 2 for main to change 85212 07/10/24, 08:05
-
Gerrit Code Review pushed patch set 3 for main to change 85212 07/10/24, 09:31
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 85198 07/12/24, 16:31
-
Garvin Hicking commented and changed status
Under ReviewResolved done0 %100 % 07/12/24, 16:35 -
Benjamin Franzke commented 08/08/24, 07:35
Just want to mention that this also affected TypoScript loaded from v13 site-sets, because packagePath ended up as
"/var/www/html///":object(TYPO3\CMS\Core\Package\Package)#294 (8) { ["partOfFactoryDefault":protected]=> bool(false) ["partOfMinimalUsableSystem":protected]=> bool(false) ["serviceProvider":protected]=> uninitialized(?string) ["packageKey":protected]=> string(15) "theme_portfolio" ["packagePath":protected]=> string(16) "/var/www/html///"…which then got ignored by the TypoScript parser once it was composed into
"/var/www/html///Configuration/Sets/ThemePortfolio"Good news is: The (already merged) patch solves this case as well :)
-
Benni Mack changed status
ResolvedClosed 10/15/24, 09:29
Applied in changeset commit:5106d8edc8d350ad56dfda7b45d1ba3f444bc372.