Issue Bug Closed

#104433EXT:form's DataStructureIdentifierListener incorrectly constructs flash messages

Christian Spoo 07/19/24, 09:02 updated 10/15/24, 09:13

Description

`\TYPO3\CMS\Form\EventListener\DataStructureIdentifierListener` has error-handling code in place that catches certain situations in which the listener is unable to modify form plugin’s Flexform definitions for certain reasons. It then displays a flash message to indicate this to the BE user. The flash message’s text is constructed from a translatable message that currently contains two positional string parameters (being the form’s identifier and the message from the exception thrown before).

The persistence identifier happened to be added to the flash message in https://github.com/TYPO3/typo3/commit/9421844a426851dca0771156d8783ad921ce4517. However the `DataStructureIdentifierListener` was never updated accordingly.

Reviews 2

History 46

  1. Garvin Hicking changed Related to #102557 07/24/24, 12:55

  2. Gerrit Code Review pushed patch set 1 for main to change 85344 status New Under Review 07/24/24, 12:58

  3. Garvin Hicking commented 07/24/24, 12:58

    Could you check out the patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/85344 and see if that works? :)

  4. Gerrit Code Review pushed patch set 1 for 12.4 to change 85380 07/25/24, 12:39

  5. Garvin Hicking commented and changed status Under Review Resolved done 0 % 100 % 07/25/24, 12:50

    Applied in changeset commit:cf36f16f4273eec17294c3d21c9ba48d4915f77b.

  6. Benni Mack changed status Resolved Closed 10/15/24, 09:13