Issue Bug Closed

#104487checkboxToggle doesn't apply `inline` keyword

Thomas Rawiel 07/26/24, 15:08 updated 10/15/24, 09:08

Description

Using the property cols=“inline” doesn’t have an effect for checkboxes with renderType checkboxToggle.

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTCAcolumns('tt_content', [
        'checkboxes' => [
            'exclude' => false,
            'label' => 'Checkbox Default',
            'config' => [
                'type' => 'check',
                'cols' => 'inline',
                'items' => [
                    ['label' => 'checkbox item',],
                    ['label' => 'checkbox item',],
                    ['label' => 'checkbox item',],
                    ['label' => 'checkbox item',],
                ],
            ],
        ],
        'checkboxes2' => [
            'exclude' => false,
            'label' => 'Checkbox Toggle',
            'config' => [
                'type' => 'check',
                'renderType' => 'checkboxToggle',
                'cols' => 'inline',
                'items' => [
                    ['label' => 'checkbox item',],
                    ['label' => 'checkbox item',],
                    ['label' => 'checkbox item',],
                    ['label' => 'checkbox item',],
                ],
            ],
        ],
        'checkboxes3' => [
            'exclude' => false,
            'label' => 'Checkbox Labeled Toggle',
            'config' => [
                'type' => 'check',
                'renderType' => 'checkboxLabeledToggle',
                'cols' => 'inline',
                'items' => [
                    ['label' => 'checkbox item', 'labelChecked' => 'Active', 'labelUnchecked' => 'Inactive'],
                    ['label' => 'checkbox item', 'labelChecked' => 'Active', 'labelUnchecked' => 'Inactive'],
                    ['label' => 'checkbox item', 'labelChecked' => 'Active', 'labelUnchecked' => 'Inactive'],
                    ['label' => 'checkbox item', 'labelChecked' => 'Active', 'labelUnchecked' => 'Inactive'],
                ],
            ],
        ],
    ]);
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addToAllTCAtypes('tt_content', 'checkboxes,checkboxes2,checkboxes3');

Expectation: all checkboxes are displayed inline for every checkbox field.

In the class TYPO3\CMS\Backend\Form\Element\CheckboxToggleElement function renderSingleCheckboxElement the variable $inline is setup like in the other 2 checkbox classe but remains unused.

It seems that was removed here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78547

Suggested fix: either remove it for the other two as well or re-add it for checkboxToggle

Reviews 2

Files 1

History 38

  1. Gerrit Code Review pushed patch set 1 for main to change 85439 status New Under Review 08/01/24, 19:01

  2. Gerrit Code Review pushed patch set 2 for main to change 85439 08/01/24, 19:07

  3. Gerrit Code Review pushed patch set 3 for main to change 85439 08/01/24, 19:35

  4. Gerrit Code Review pushed patch set 4 for main to change 85439 08/01/24, 19:37

  5. Corinne van der Zande commented and changed status Under Review Resolved done 0 % 100 % 08/03/24, 12:40

    Applied in changeset commit:d7987a771296af67763b7980e9bb2be584e4de42.

  6. Gerrit Code Review pushed patch set 1 for 12.4 to change 85504 status Resolved Under Review 08/03/24, 12:46

  7. Corinne van der Zande commented and changed status Under Review Resolved 08/03/24, 13:00

    Applied in changeset commit:389748946c80900e96378b29f85621d71d75d6e6.

  8. Benni Mack changed status Resolved Closed 10/15/24, 09:08