#104536Add PhpStand max failure to baseline
Description
------ -------------------------------------------------------------------
Line core/Classes/DataHandling/SlugHelper.php
------ -------------------------------------------------------------------
128 Regex pattern is invalid: Compilation failed: quantifier does not
follow a repeatable item at offset 5 in pattern: /.*{2,}/
:identification_card: regexp.pattern
------ -------------------------------------------------------------------
We could not find the reason for that mangled regex and think it is a bug in phpstan. In order got return a nice green status to our nightly CI, the error is added to the baseline and reviewed later on, when a reason is found.
Reviews 2
History 49
-
Gerrit Code Review pushed patch set 1 for main to change 85484 status
NewUnder Review <span data-processor="relativetime" data-value="2024-08-02T08:33:03+00:00" > 08/02/24, 08:33 </span> -
Andreas Wolf commented <span data-processor="relativetime" data-value="2024-08-02T09:35:35+00:00" > 08/02/24, 09:35 </span>
The issue was already fixed in PhpStan: https://github.com/phpstan/phpstan-src/commit/164691dfb89d73b34d46bf07fc6771e6f507d946
So it will likely be good in the next release. I would thus add a “conflict” for PhpStan 1.11.9 or change the constraint to “^1.11.8 !1.11.9”.
-
Gerrit Code Review pushed patch set 2 for main to change 85484 <span data-processor="relativetime" data-value="2024-08-02T11:48:49+00:00" > 08/02/24, 11:48 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 85484 <span data-processor="relativetime" data-value="2024-08-02T14:10:50+00:00" > 08/02/24, 14:10 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 85484 <span data-processor="relativetime" data-value="2024-08-02T14:11:14+00:00" > 08/02/24, 14:11 </span>
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 85494 <span data-processor="relativetime" data-value="2024-08-02T14:13:09+00:00" > 08/02/24, 14:13 </span>
-
Anja Leichsenring commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2024-08-02T14:25:08+00:00" > 08/02/24, 14:25 </span>Applied in changeset commit:2fc9f438595a8532bc8c3e6be0bbee3f9bb1ac11.
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2024-10-15T09:08:48+00:00" > 10/15/24, 09:08 </span>
I found no occurrence of ‘.*’ as a pattern.
Also it does not make sense, the line:
$value = (string)preg_replace('/' . preg_quote($fallbackCharacter) . '{2,}/', $fallbackCharacter, $value);will never produce the regex
/.*{2,}/.