#104590`substituteMarkerArray` should ignore `(array)`
Description
--- vendor/typo3/cms-core/Classes/Service/MarkerBasedTemplateService.bak 2024-08-11 20:52:35.812856063 +0200
+++ vendor/typo3/cms-core/Classes/Service/MarkerBasedTemplateService.php 2024-08-11 20:52:35.812856063 +0200
@@ -208,6 +208,9 @@
$search = [];
$replace = [];
foreach ($markContentArray as $marker => $markContent) {
+ if (is_array($markContent)) {
+ continue;
+ }
expl.
sourceCollection {
UHD8 {
dataKey = UHD8
width = 7680
mediaQuery = (max-width: 7680px),(max-width: 3840px) and (min-resolution: 2dppx)
if.isLessThan.data = field:width // file:current:width
if.value < .width
if.negate = 1
}Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
History 9
-
Marcus Förster changed target version 08/11/24, 19:07
-
Marcus Förster changed description 08/12/24, 15:34
-
Marcus Förster changed tracker
FeatureBug TYPO3 Version 12 03/16/25, 13:36 -
Georg Ringer changed Sprint Focus On Location Sprint 04/16/25, 09:37
-
Garvin Hicking commented and changed status
NewNeeds Feedback 05/23/25, 11:57 -
Marcus Förster commented 05/23/25, 12:05
Garvin Hicking wrote in #note-5:
> Could you please provide details, thanks!not shure what else to provide ; you can see that “if” is an array which throws a warning @ https://github.com/TYPO3/typo3/blob/2f3bdf6e4f974ef882d27adddd74e574ca5bad4a/typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php#L226
-
Garvin Hicking commented 05/23/25, 12:14
I would just like to know what I can easily do to get the error behaviour, to be sure that this patch fixes the issue.
The patch currently just ignores arrays, but I wonder how an array gets into there, and what it holds – because no substitution would then be performed. So to me this feels as if there is a different underlying problem and we would need to address why a multidimension array gets in here.
-
Marcus Förster commented 05/23/25, 12:27
str_replace does not accept array => may filter it before :)
-
Garvin Hicking commented and changed status
Needs FeedbackRejected 07/13/25, 20:06Lacking details to understand/reproduce, I’m sorry but we need to close unclear issues.
Could you please provide details, thanks!