Issue Feature Closed

#104655Add console command to mark upgrade wizards as undone

Till Hörner 08/18/24, 09:53 updated 10/15/24, 09:09

Description

*Problem:*
Currently it is not possible to run an already marked as done upgrade wizard from CLI. You have to go to the install tool, mark the wizard as undone and then run it again.

*Solution:*
Add a new “upgrade:markUndone” command to make it possible to mark an upgrade wizard as undone.

Reviews 2

History 711

  1. Gerrit Code Review pushed patch set 1 for main to change 85672 status New Under Review 08/18/24, 09:55

  2. Gerrit Code Review pushed patch set 2 for main to change 85672 08/19/24, 07:14

  3. Garvin Hicking commented 08/27/24, 19:15

    From gerrit, crossposted:

    Small update: We discussed this internally without a clear consent.

    We feel that probably to align with the GUI in the backend it would be more “sane” to reflect functionality there, which means: introduce a “upgrade:markUndone” command.

    So, the goal would be to replicate the GUI functionality for the CLI, with the same methodology:

    Either execute a wizard
    … or mark a wizard as “I don’t want this” (like installing EXT:compatibility in the past)
    … or “leave it hanging around”

    Plus, the GUI allows to mark an executed wizard as undone, so it can be executed again.

    Adding a “force” option to this command could trick people into thinking “I add this —force command always, to make sure the wizard runs”, but then wizards could accidentally run twice.

    What do you or others think?

  4. Till Hörner commented 08/28/24, 06:41

    I think the main point is to make it possible to run an already marked as done upgrade wizard from CLI only. As said before I was used to the —force flag from TYPO3 Console, but I understand the concern and think a separate “upgrade:markUndone” command would be fine too.

  5. Garvin Hicking commented 08/28/24, 07:48

    Thanks for your understanding and patience… would you maybe be interested to rework your patch to introduce such a command? :-)

  6. Till Hörner commented and changed tracker Task Feature subject Add force option to upgrade:run command Add console command to mark upgrade wizards as undone description TYPO3 Version 12 08/28/24, 15:29

    Yes, I’d like to give it a try ;)

  7. Gerrit Code Review pushed patch set 3 for main to change 85672 08/28/24, 18:18

  8. Garvin Hicking commented 08/29/24, 07:29

    Hi Till,

    this is great, thanks so much for the contribution. We’ll review it and give feedback on Gerrit, do you get notices/replies there?

  9. Gerrit Code Review pushed patch set 4 for main to change 85672 08/29/24, 15:36

  10. Till Hörner commented and changed status Under Review Resolved done 0 % 100 % 09/04/24, 18:40

    Applied in changeset commit:b99439613cc2ca553c3be17eedd690b981ca9233.

  11. Benni Mack changed status Resolved Closed 10/15/24, 09:09