#105152503 when editor has no access to the default storage #2
Description
The bug (tried) to fix here: https://forge.typo3.org/issues/103897
is still an open bug here: typo3/cms-filelist/Classes/LinkHandler/AbstractResourceLinkHandler.php:198
where the same condition is used.
if (!$this->selectedFolder) {
$this->selectedFolder = $this->resourceFactory->getDefaultStorage()?->getRootLevelFolder() ?? null;
}
How to reproduce:
- Create a text element
- Add some text
- Link the text
- Select “File” in the opening dialog
- Booomm
Solution is the same as in the already published fix:
if (!$this->selectedFolder) {
$allStorages = $this->getBackendUser()->getFileStorages();
$defaultStorage = $this->resourceFactory->getDefaultStorage();
if ($defaultStorage && array_key_exists($defaultStorage->getUid(), $allStorages)) {
$this->selectedFolder = $defaultStorage->getRootLevelFolder();
} else {
$this->selectedFolder = reset($allStorages)->getRootLevelFolder();
}
}Reviews 9
- 12.4 88226[BUGFIX] Harden IconForResourceViewHelper to prevent filemount errors
- main 87946[BUGFIX] Update FAL error handling in element browser
- 13.4 88225[BUGFIX] Harden IconForResourceViewHelper to prevent filemount errors
- main 88209[BUGFIX] Harden IconForResourceViewHelper to prevent filemount errors
- 12.4 87962[BUGFIX] Update FAL error handling in element browser
- 13.4 87961[BUGFIX] Update FAL error handling in element browser
- 12.4 87957[BUGFIX] Update FAL error handling in link browser
- 13.4 87956[BUGFIX] Update FAL error handling in link browser
- main 87872[BUGFIX] Update FAL error handling in link browser
Related issues 4
- Bug #100959File storage 'fileadmin' as default storage must be allowed for editors to show other other filemounts in other file storages
- Bug #103897Reproducable 503 when editor has no access to the default storage
- Bug #106038Avoid exception in file element browser
- Bug #106173BUGFIX b1e36ce3dae (TYPO3 12.4.27) breaks entry point selection at Filemount
History 818
-
Wolfgang Klinger changed Related to #103897 <span data-processor="relativetime" data-value="2024-09-27T11:22:45+00:00" > 09/27/24, 11:22 </span>
-
Tobias Wollender commented <span data-processor="relativetime" data-value="2025-01-10T21:58:42+00:00" > 01/10/25, 21:58 </span>
We also had this problem today (with TYPO3 12.4.24). Thanks for the proposed fix, which worked as described.
-
Gerrit Code Review pushed patch set 1 for main to change 87872 status
NewUnder Review <span data-processor="relativetime" data-value="2025-01-24T09:29:51+00:00" > 01/24/25, 09:29 </span> -
Gerrit Code Review pushed patch set 2 for main to change 87872 <span data-processor="relativetime" data-value="2025-01-24T09:56:51+00:00" > 01/24/25, 09:56 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 87872 <span data-processor="relativetime" data-value="2025-01-24T09:58:21+00:00" > 01/24/25, 09:58 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 87872 <span data-processor="relativetime" data-value="2025-01-24T09:58:48+00:00" > 01/24/25, 09:58 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 87872 <span data-processor="relativetime" data-value="2025-01-30T07:03:58+00:00" > 01/30/25, 07:03 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 87872 <span data-processor="relativetime" data-value="2025-01-30T18:38:02+00:00" > 01/30/25, 18:38 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 87872 <span data-processor="relativetime" data-value="2025-01-30T18:39:42+00:00" > 01/30/25, 18:39 </span>
-
Christian Kuhn changed Related to #106038 <span data-processor="relativetime" data-value="2025-01-30T21:42:58+00:00" > 01/30/25, 21:42 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 87872 <span data-processor="relativetime" data-value="2025-01-31T09:17:31+00:00" > 01/31/25, 09:17 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 87956 <span data-processor="relativetime" data-value="2025-01-31T11:55:01+00:00" > 01/31/25, 11:55 </span>
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 87957 <span data-processor="relativetime" data-value="2025-01-31T11:55:45+00:00" > 01/31/25, 11:55 </span>
-
Fabian Schiller commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-01-31T12:25:13+00:00" > 01/31/25, 12:25 </span>Applied in changeset commit:533a0f8b6e5d139d63e455f09f57486c53a20860.
-
Garvin Hicking changed Related to #106173 <span data-processor="relativetime" data-value="2025-02-13T18:01:50+00:00" > 02/13/25, 18:01 </span>
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:32:48+00:00" > 12/02/25, 14:32 </span> -
Benni Mack changed Related to #100959 <span data-processor="relativetime" data-value="2026-11-13T13:02:17+00:00" > 11/13/26, 13:02 </span>
Can confirm, editors without access to default storage opening link browser in file mode just throws exception 1375955684.