Issue Task Closed

#105365TCA: FormEngineValidation.processValue() does not always use declared return type

Ayke Halder 10/19/24, 19:49 updated 12/02/25, 14:32

Description

FormEngineValidation.processValue with argument 'integer' actually returns number instead of string:

FormEngineValidation.processValue = function(…): string {}

FormEngineValidation.processValue('integer', …) {
  return … someValue as number
}

Call-chain – the return type of these functions is declared as string:

FormEngineValidation.updateInputField = function(…): void {
  (someField as HTMLInputElement).value: string = FormEngineValidation.processByEvals(…) as number
}

FormEngineValidation.processByEvals = function(…): string {
  return … FormEngineValidation.processValue(…) as number
}

FormEngineValidation.processValue = function(…): string {
  return … someValue as number
}

Reviews 5

History 411

  1. Ayke Halder changed Related to #105366 10/19/24, 20:24

  2. Gerrit Code Review pushed patch set 1 for main to change 86660 status New Under Review 10/19/24, 20:28

  3. Gerrit Code Review pushed patch set 2 for main to change 86660 10/20/24, 12:58

  4. Gerrit Code Review pushed patch set 1 for main to change 86822 10/29/24, 12:01

  5. Gerrit Code Review pushed patch set 2 for main to change 86822 10/29/24, 13:42

  6. Gerrit Code Review pushed patch set 3 for main to change 86822 10/29/24, 14:19

  7. Gerrit Code Review pushed patch set 4 for main to change 86822 10/30/24, 08:09

  8. Benjamin Franzke changed tracker Bug Task TYPO3 Version 12 13 10/30/24, 08:09

  9. Gerrit Code Review pushed patch set 1 for 13.4 to change 86833 10/30/24, 08:53

  10. Anonymous commented and changed status Under Review Resolved done 0 % 100 % 10/30/24, 09:05

    Applied in changeset commit:d5ef710533722b4d893e8cb20265139ecd979c85.

  11. Benni Mack changed status Resolved Closed 12/02/25, 14:32