#105365TCA: FormEngineValidation.processValue() does not always use declared return type
Description
FormEngineValidation.processValue with argument 'integer' actually returns number instead of string:
FormEngineValidation.processValue = function(…): string {}
FormEngineValidation.processValue('integer', …) {
return … someValue as number
}
Call-chain – the return type of these functions is declared as string:
FormEngineValidation.updateInputField = function(…): void {
(someField as HTMLInputElement).value: string = FormEngineValidation.processByEvals(…) as number
}
FormEngineValidation.processByEvals = function(…): string {
return … FormEngineValidation.processValue(…) as number
}
FormEngineValidation.processValue = function(…): string {
return … someValue as number
}Reviews 5
- 13.4 86843[TASK] Transform FormEngineValidation into a TypeScript class
- main 86663[TASK] Transform FormEngineValidation into a TypeScript class
- 13.4 86833[TASK] Return string in FormEngine `integer` parsing
- main 86822[TASK] Return string in FormEngine `integer` parsing
- main 86660[BUGFIX] Respect already declared return type in `FormEngineValidation`
Related issues 1
History 411
-
Ayke Halder changed Related to #105366 10/19/24, 20:24
-
Gerrit Code Review pushed patch set 1 for main to change 86660 status
NewUnder Review 10/19/24, 20:28 -
Gerrit Code Review pushed patch set 2 for main to change 86660 10/20/24, 12:58
-
Gerrit Code Review pushed patch set 1 for main to change 86822 10/29/24, 12:01
-
Gerrit Code Review pushed patch set 2 for main to change 86822 10/29/24, 13:42
-
Gerrit Code Review pushed patch set 3 for main to change 86822 10/29/24, 14:19
-
Gerrit Code Review pushed patch set 4 for main to change 86822 10/30/24, 08:09
-
Benjamin Franzke changed tracker
BugTask TYPO3 Version1213 10/30/24, 08:09 -
Gerrit Code Review pushed patch set 1 for 13.4 to change 86833 10/30/24, 08:53
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % 10/30/24, 09:05 -
Benni Mack changed status
ResolvedClosed 12/02/25, 14:32
Applied in changeset commit:d5ef710533722b4d893e8cb20265139ecd979c85.