Issue Bug Closed

#105411IconFactory->getIconForRecord allows invalid $size value

Andreas Kienast 10/23/24, 13:21 updated 12/02/25, 14:32

Description

The method IconFactory->getIconForRecord() allows to set the $size parameter to null. This argument is then passed to IconFactory->getIcon() which will lead to a TypeError, as null is not allowed there.

Reviews 2

History 37

  1. Gerrit Code Review pushed patch set 1 for main to change 86711 status In Progress Under Review <span data-processor="relativetime" data-value="2024-10-23T13:22:48+00:00" > 10/23/24, 13:22 </span>

  2. Anonymous commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2024-10-23T18:05:07+00:00" > 10/23/24, 18:05 </span>

    Applied in changeset commit:7ee75f3860072dcdfca985a4dbc0ff9169de512f.