Issue Bug Closed

#105446lib.parseFunc_RTE and lib.parseFunc no longer have a allowTags default

Garvin Hicking 10/24/24, 14:16 updated 08/12/25, 14:36

Description

With #104220 a change of behaviour was introduced that no longer sets `lib.parseFunc_RTE.allowTags = {$styles.content.allowTags}`.

If custom extensions like a sitepackage however previously used this code:

lib.parseFunc.allowTags := addToList(wbr)
lib.parseFunc_RTE.allowTags := addToList(wbr)

then addToList would actually set the previously empty allowTags ONLY to “wbr”. This would then deny any tag besides “wbr”, and not just allow “wbr” additionally to the previous default.

(Currently, this is not listed as an intentional breaking change)

Reviews 3

History 414

  1. Garvin Hicking changed Related to #104220 10/24/24, 14:19

  2. Gerrit Code Review pushed patch set 1 for main to change 86763 status Accepted Under Review 10/24/24, 14:21

  3. Benni Mack commented 11/22/24, 08:51

    The problem is that we check for === ‘‘ and not “inList(’’)’ which would solve the issue!

  4. Gerrit Code Review pushed patch set 1 for main to change 87164 11/22/24, 09:00

  5. Gerrit Code Review pushed patch set 2 for main to change 87164 11/25/24, 12:15

  6. Gerrit Code Review pushed patch set 2 for main to change 86763 11/25/24, 12:20

  7. Gerrit Code Review pushed patch set 3 for main to change 86763 11/25/24, 12:20

  8. Gerrit Code Review pushed patch set 3 for main to change 87164 12/03/24, 10:50

  9. Gerrit Code Review pushed patch set 4 for main to change 87164 12/03/24, 11:24

  10. Gerrit Code Review pushed patch set 4 for main to change 86763 12/10/24, 07:13

  11. Gerrit Code Review pushed patch set 1 for 13.4 to change 87412 12/10/24, 08:27

  12. Gerrit Code Review pushed patch set 2 for 13.4 to change 87412 12/10/24, 10:20

  13. Benni Mack commented and changed status Under Review Resolved done 0 % 100 % 12/10/24, 10:30

    Applied in changeset commit:cf0f288c8e2a3da3c023d30ef9c505b48f408d6d.

  14. Benni Mack changed status Resolved Closed 08/12/25, 14:36