#105592The TypoScript option "external" must be evaluated before an external CSS/JS resource gets included
Description
Problem/Description
In https://review.typo3.org/c/Packages/TYPO3.CMS/+/27130 the functionality was removed. Looks like the regression exists for about 10 years
Example:
- page.includeCSS.1 must be included
- page.includeCSS.2 must NOT be included
page.includeCSS {
1 = https://unpkg.com/open-props
2 = https://unpkg.com/open-props/normalize.min.css
1.external = 1
2.external = 0
}
page.includeCSS.2 gets also included without applying any patch to the TYPO3 core.
ToDo(s)
- Re-add check if the url to js/css resource begins with https, http or // and only include it if external option is set.
Acceptance Criteria
- The external JS/CSS includes must work like it was before some time ago
- The external JS/CSS includes must work like it is documented (Link to documentation)
Reviews 2
Related issues 2
History 713
-
Gerrit Code Review pushed patch set 2 for main to change 86983 status
NewUnder Review <span data-processor="relativetime" data-value="2024-11-13T15:17:50+00:00" > 11/13/24, 15:17 </span> -
Josef Glatz changed description <span data-processor="relativetime" data-value="2024-11-13T15:20:35+00:00" > 11/13/24, 15:20 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 86983 <span data-processor="relativetime" data-value="2024-11-14T06:52:09+00:00" > 11/14/24, 06:52 </span>
-
Josef Glatz changed description <span data-processor="relativetime" data-value="2024-11-14T06:57:13+00:00" > 11/14/24, 06:57 </span>
-
Josef Glatz changed description <span data-processor="relativetime" data-value="2024-11-14T07:30:30+00:00" > 11/14/24, 07:30 </span>
-
Josef Glatz changed description <span data-processor="relativetime" data-value="2024-11-14T08:40:06+00:00" > 11/14/24, 08:40 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 86983 <span data-processor="relativetime" data-value="2025-01-21T12:28:08+00:00" > 01/21/25, 12:28 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 86983 <span data-processor="relativetime" data-value="2025-03-13T20:07:20+00:00" > 03/13/25, 20:07 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 86983 <span data-processor="relativetime" data-value="2025-03-13T20:07:40+00:00" > 03/13/25, 20:07 </span>
-
Garvin Hicking changed Related to #55442 <span data-processor="relativetime" data-value="2025-04-12T11:28:49+00:00" > 04/12/25, 11:28 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 91350 <span data-processor="relativetime" data-value="2025-10-30T07:39:44+00:00" > 10/30/25, 07:39 </span>
-
Helmut Hummel changed Related to #107927 <span data-processor="relativetime" data-value="2025-11-14T10:57:36+00:00" > 11/14/25, 10:57 </span>
-
Helmut Hummel commented and changed status
Under ReviewRejected <span data-processor="relativetime" data-value="2025-11-14T11:29:52+00:00" > 11/14/25, 11:29 </span>
I will close this one in favour of #107927