Issue Bug Closed

#105755TCA Type Inline -> Upload sometimes does not work

Tiran Grigoryan 12/03/24, 16:40 updated 12/02/25, 14:31

Description

With TCA Type Inline, the Upload field sometimes does not work if you enter several data records without clicking on Save. However, as soon as you save, the field works again. Please fix this urgently. The editors are already annoyed about this.

Reviews 2

Files 1

History 1619

  1. Garvin Hicking commented and changed status New Needs Feedback <span data-processor="relativetime" data-value="2024-12-03T16:45:08+00:00" > 12/03/24, 16:45 </span>

    Can you give more details to reproduce this? “Sometimes” is hard to get into inspecting this.

    If you can provide reproducible steps, maybe errors in the browser console, failed network requests, or the DOM state once it fails to work, or screenshots/videos, that will increase the likelihood that someone will work for free on this.

  2. Tiran Grigoryan commented and changed attached Typo3 Core Bug By TCA Inline.mp4 <span data-processor="relativetime" data-value="2024-12-03T17:01:14+00:00" > 12/03/24, 17:01 </span>

    Garvin Hicking wrote in #note-1:
    > Can you give more details to reproduce this? “Sometimes” is hard to get into inspecting this.
    >
    > If you can provide reproducible steps, maybe errors in the browser console, failed network requests, or the DOM state once it fails to work, or screenshots/videos, that will increase the likelihood that someone will work for free on this.

    Sorry, here I have made the steps in video and hope that you can get it reproduced

  3. Garvin Hicking commented <span data-processor="relativetime" data-value="2024-12-03T17:45:49+00:00" > 12/03/24, 17:45 </span>

    Hm, that video is only 22kb and doesn’t load for me? If it’s too large maybe you can upload it to vimeo or youtube or so?

  4. Tiran Grigoryan commented <span data-processor="relativetime" data-value="2024-12-03T18:40:04+00:00" > 12/03/24, 18:40 </span>

    Garvin Hicking wrote in #note-3:
    > Hm, that video is only 22kb and doesn’t load for me? If it’s too large maybe you can upload it to vimeo or youtube or so?

    https://www.loom.com/share/b213fad0a9384a8b9418a0ca75378533?sid=05754950-1068-4e5c-8b57-325d788efd62

  5. Tiran Grigoryan commented <span data-processor="relativetime" data-value="2024-12-04T14:12:03+00:00" > 12/04/24, 14:12 </span>

    Tiran Grigoryan wrote in #note-4:
    > Garvin Hicking wrote in #note-3:
    > > Hm, that video is only 22kb and doesn’t load for me? If it’s too large maybe you can upload it to vimeo or youtube or so?
    >
    > https://www.loom.com/share/b213fad0a9384a8b9418a0ca75378533?sid=05754950-1068-4e5c-8b57-325d788efd62

    Garvin Hicking wrote in #note-3:
    > Hm, that video is only 22kb and doesn’t load for me? If it’s too large maybe you can upload it to vimeo or youtube or so?

    Could you reproduce it?

  6. Garvin Hicking commented <span data-processor="relativetime" data-value="2024-12-04T22:31:14+00:00" > 12/04/24, 22:31 </span>

    I could view the video but didn’t find time today. Should be able to have a look tomorrow.

  7. Garvin Hicking commented and changed status Needs Feedback Accepted priority Should have Must have <span data-processor="relativetime" data-value="2024-12-05T08:12:49+00:00" > 12/05/24, 08:12 </span>

    Yes, I can reproduce it now. Thank you!

    For TYPO3 v14 main (and v13 below) this can be reproduced via EXT:styleguide:

    • Create an element of Type “Form engine – inline expand”
    • In “inline_1” click on “Create new”
    • New section gets added to the bottom
    • Clicking on “Select & upload files” there: works
    • Click on “Create new” once more
    • Clicking on “Select & upload files” on the second element: DOES NOT WORK
    • Clicking on “Select & upload files” on the first element: still works

    Feels like wrong DOM element triggering/targetting, needs further inspection. I raised the priority on this.

  8. Tiran Grigoryan commented <span data-processor="relativetime" data-value="2024-12-09T16:04:33+00:00" > 12/09/24, 16:04 </span>

    Garvin Hicking wrote in #note-7:
    > Yes, I can reproduce it now. Thank you!
    >
    > For TYPO3 v14 main (and v13 below) this can be reproduced via EXT:styleguide:
    >
    > * Create an element of Type “Form engine – inline expand“
    > * In “inline_1” click on “Create new“
    > * New section gets added to the bottom
    > * Clicking on “Select & upload files” there: works
    > * Click on “Create new” once more
    > * Clicking on “Select & upload files” on the second element: *DOES NOT WORK*
    > * Clicking on “Select & upload files” on the first element: still works
    >
    > Feels like wrong DOM element triggering/targetting, needs further inspection. I raised the priority on this.

    When will this bug be fixed? It’s very stupid that customers can’t maintain their things, they remain dissatisfied with us. Can I help you to fix it as soon as possible?

  9. Garvin Hicking commented <span data-processor="relativetime" data-value="2024-12-09T18:22:34+00:00" > 12/09/24, 18:22 </span>

    I cannot tell you this with certainty, when the bug can be fixed. Please also try to refrain from using words like “stupid”, because it easily triggers people to feel offended.

    Progress is made by volunteers or people who are interested in the product, and by very very few companies that pay their developers to work on TYPO3. They have a lot of tasks (see how many open issues this tracker has). We do our best, and everyone has a special area to work in. Sadly, the javascript of this is a bit more complex.

    Me and two other core developers already spent a few hours on this, but there was no simple solution.

    Do you or your company have people with JavaScript skills? We could talk and I can give pointers where they can help, indeed! The base problem is that no javascript event is delegated/fored to re-trigger the dragzone init constructor.

    (Luckily for your reported bug, there’s the mentioned workaround in place for saving a new entry first. Many other open bugs don’t have workarounds in place)

    Best regards.
    Garvin

  10. Tiran Grigoryan commented <span data-processor="relativetime" data-value="2024-12-10T06:15:38+00:00" > 12/10/24, 06:15 </span>

    Garvin Hicking wrote in #note-9:
    > I cannot tell you this with certainty, when the bug can be fixed. Please also try to refrain from using words like “stupid”, because it easily triggers people to feel offended.
    >
    > Progress is made by volunteers or people who are interested in the product, and by very very few companies that pay their developers to work on TYPO3. They have a lot of tasks (see how many open issues this tracker has). We do our best, and everyone has a special area to work in. Sadly, the javascript of this is a bit more complex.
    >
    > Me and two other core developers already spent a few hours on this, but there was no simple solution.
    >
    > Do you or your company have people with JavaScript skills? We could talk and I can give pointers where they can help, indeed! The base problem is that no javascript event is delegated/fored to re-trigger the dragzone init constructor.
    >
    > (Luckily for your reported bug, there’s the mentioned workaround in place for saving a new entry first. Many other open bugs don’t have workarounds in place)
    >
    > Best regards.
    > Garvin
    Hi Garvin,

    Sorry about ‘stupid’ word. My English is not so good. And the translator app translated it that way, I speak German. I didn’t mean to offend anyone.
    Some customers react very aggressively to a mistake or little thing that doesn’t work.
    I am a backend developer and also have knowledge of JavaScript. I would also like to support you in the backend + JavaScript tasks, if it should be

  11. Gerrit Code Review pushed patch set 1 for main to change 87409 status Accepted Under Review <span data-processor="relativetime" data-value="2024-12-10T07:16:15+00:00" > 12/10/24, 07:16 </span>

  12. Garvin Hicking commented <span data-processor="relativetime" data-value="2024-12-10T08:07:06+00:00" > 12/10/24, 08:07 </span>

    @t.grigoryan Thanks for taking the time to explain this. I understand you get pressure from clients, and we must try to still act without too much pressure.

    Andreas Kienast created a patch today which I verified working: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87409

    Please have a try and vote on the patch if you can verify it works for you, too.

  13. Tiran Grigoryan commented <span data-processor="relativetime" data-value="2024-12-10T21:35:45+00:00" > 12/10/24, 21:35 </span>

    Garvin Hicking wrote in #note-14:
    > @t.grigoryan Thanks for taking the time to explain this. I understand you get pressure from clients, and we must try to still act without too much pressure.
    >
    > Andreas Kienast created a patch today which I verified working: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87409
    >
    > Please have a try and vote on the patch if you can verify it works for you, too.

    Works for me, thank you very much.

  14. Anonymous commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2024-12-11T13:10:09+00:00" > 12/11/24, 13:10 </span>

    Applied in changeset commit:0205629a50c6739a57097225f8ae2b8d2c269d9c.