Issue Bug Closed

#105883Recycler does not work for editors unless they may also delete records

Lina Wolf 01/04/25, 16:38 updated 12/02/25, 14:27

Description

TYPO3 13.4.2

Non-admin editors cannot see any items in the recycler unless the page TSconfig option

# Allow the editors to delete records
mod.recycler.allowDelete = 1

is set. This option allows editors to permanently delete records. So there are valid use
cases where editors should be able to use the reset feature without being able to permanently
delete records

Reviews 2

Files 1

History 410

  1. Ursula Klinger commented 01/28/25, 18:42

    Hi,

    we debugged this today. We think it is a javascript error (visible in the developer console),
    where “remove” is called on a non-existing massDelete button (document.querySelector(Identifiers.massDelete).remove()).
    The same happens with the style (document.querySelector(Identifiers.massDelete).style.display).
    Unfortunately we could not fix the error ourselves, because we only see the public javascript file.
    We hope this helps somebody to fix it.

  2. Garvin Hicking commented 01/28/25, 21:06

    Hi Ursula,

    Thanks for offering to help. I’m a bit unsure if this is really related, but it shouldn’t hurt to help analyzing the JavaScript.

    The .js files are built from the TYPO3 core monorepository. You could:

    - check out the GIT repository of the matching TYPO3 release you use
    - find the .ts file in the /Build/Sources/ structure of the GIT repo
    - make changes
    - run the command ./Build/Scripts/runTests.sh -s buildJavascript which will create the updated .js file
    - copy that js file to your actual instance
    - reload browser cache to ensure the new JS is used
    - debug, rinse, repeat

    (If you set-up the monorepository as an actual TYPO3 instance you could use a JS build watch task to constantly update the .js file(s) to speed up the process)

    Maybe this helps to get you into it? Thanks for helping !

  3. Gerrit Code Review pushed patch set 1 for main to change 88173 status New Under Review 02/11/25, 18:28

  4. Gerrit Code Review pushed patch set 2 for main to change 88173 02/11/25, 18:45

  5. Gerrit Code Review pushed patch set 3 for main to change 88173 02/12/25, 07:08

  6. Gerrit Code Review pushed patch set 4 for main to change 88173 02/12/25, 08:18

  7. Gerrit Code Review pushed patch set 5 for main to change 88173 02/14/25, 07:53

  8. Gerrit Code Review pushed patch set 1 for 13.4 to change 88233 02/16/25, 16:59

  9. Ursula Klinger commented and changed status Under Review Resolved done 0 % 100 % 02/17/25, 10:00

    Applied in changeset commit:c29a7ce903995a98a5f4e1760c3bc25b1b144b92.

  10. Benni Mack changed status Resolved Closed 12/02/25, 14:27