#105897Usage of Exception getPrevious() in DataHandler may throw excpeption
Description
in v12 DataHandler line 7817:
try {
// Execute the INSERT query:
$connection->insert($table, $fieldArray);
} catch (DBALException $e) {
$insertErrorMessage = $e->getPrevious()->getMessage();
}
If an exception is thrown in insert and the “catch” block reached, Using the following line may cause another error / exception, where the original exception is no longer displayed:
$insertErrorMessage = $e->getPrevious()->getMessage();
Reason is the getPrevious() will not always return something.
- original exception: Doctrine\DBAL\Types\ConversionException: “Could not convert PHP value 1736118000 to type date. Expected one of the following types: null, string, DateTime”, previous=null
- displayed Error: Call to a member function getMessage() on null
Reproduce
Can be reproduced, if you have configured a field with type “datetime”, but the field in the database is DATE (not int) and ‘dbType’ => ‘date’ is not set, then try to create a new record in the BE.
TCA config:
'config' => [
'type' => 'datetime',
'format' => 'date',
//'dbType' => 'date',
'size' => 7,
'default' => null,
]
SQL schema:
| date_published | date | YES | | NULL |
Versions
- reproduced in v12
- code for v14 looks similar
Screenshot
Reviews 3
Related issues 2
Files 1
History 413
-
Gerrit Code Review pushed patch set 1 for main to change 87711 status
NewUnder Review <span data-processor="relativetime" data-value="2025-01-13T11:59:35+00:00" > 01/13/25, 11:59 </span> -
Garvin Hicking changed Related to #105565 <span data-processor="relativetime" data-value="2025-01-13T12:25:51+00:00" > 01/13/25, 12:25 </span>
-
Gerrit Code Review pushed patch set 2 for main to change 87711 <span data-processor="relativetime" data-value="2025-01-13T12:33:29+00:00" > 01/13/25, 12:33 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 87711 <span data-processor="relativetime" data-value="2025-01-13T12:35:00+00:00" > 01/13/25, 12:35 </span>
-
Benni Mack changed Related to #105919 <span data-processor="relativetime" data-value="2025-01-13T13:15:32+00:00" > 01/13/25, 13:15 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 87711 <span data-processor="relativetime" data-value="2025-01-13T13:15:49+00:00" > 01/13/25, 13:15 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 87711 <span data-processor="relativetime" data-value="2025-01-13T15:58:26+00:00" > 01/13/25, 15:58 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 87711 <span data-processor="relativetime" data-value="2025-01-14T12:06:31+00:00" > 01/14/25, 12:06 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 87711 <span data-processor="relativetime" data-value="2025-01-14T12:54:24+00:00" > 01/14/25, 12:54 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 87762 <span data-processor="relativetime" data-value="2025-01-14T16:43:13+00:00" > 01/14/25, 16:43 </span>
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 87763 <span data-processor="relativetime" data-value="2025-01-14T17:25:04+00:00" > 01/14/25, 17:25 </span>
-
Christian Kuhn commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-01-14T17:45:10+00:00" > 01/14/25, 17:45 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:27:11+00:00" > 12/02/25, 14:27 </span>
Applied in changeset commit:705b5bf51516821047b47ff0d4a1d643f35ed594.