#105910Wrong record icon in linkvalidator
Description
The icons rendered in the link validator result view are always the wrong ones since the data that’s being used to render them is wrong.
Here’s a excerpt from EXT:linkvalidator/Classes/Controller/LinkValidatorController.php with $row being the link validator record not the target record!
protected function generateTableRow(array $row): array
{
...
$result = [
'uid' => $row['uid'],
'recordUid' => $row['record_uid'],
'recordTable' => $table,
'recordTableTitle' => $languageService->sL($GLOBALS['TCA'][$table]['ctrl']['title'] ?? ''),
'recordTableIconDefault' => $this->iconFactory->getIconForRecord($table, $row, IconSize::SMALL)->render(),
...
}
That’s why the record icons are not the ones one would expect: correct type icon with optional overlay (for hidden=1)
Current state:
clipboard-202501101327-udbcx.png
Fixed state:
Reviews 1
Files 2
History 34
-
Gerrit Code Review pushed patch set 1 for main to change 87692 status
NewUnder Review 01/10/25, 12:42 -
Georg Ringer commented 02/10/25, 20:11
-
Philipp Kitzberger commented and changed done
0 %100 % 02/11/25, 09:30Yup, it’s working in 13.4.5 now. Thanks.
-
Garvin Hicking changed status
Under ReviewClosed 02/11/25, 21:50
fixed with https://github.com/typo3/typo3/commit/a68c980dea477bffdf786858733d3ac45f3de0bd, can you retest?