Issue Bug Closed

#105971TypolinkTagSoftReferenceParser::parse does not match if extra parameters are part of url

Soren Malling 01/21/25, 12:49 updated 12/02/25, 14:26

Description

Using the b13/link2language package, to link across languages.

The links generated now and used for resolving now contains a extra L={language} parameter. The links are as such

<a href="t3://page?uid=2879&amp;L=1#23260">

Pattern used for matching in the TypolinkTagSoftReferenceParser::parse is

preg_match('/page\?uid=(\d+)#?(\d+)?/', $matches[1], $pageAndAnchorMatches)

This is the result of mathcing against a:

  • Link to page with L parameter: <a href=“t3://page?uid=2881&L=0”> => Matches the page uid. $pageAndAnchorMatches1 being 2881
  • Link to content element on page without L parameter: <a href=“t3://page?uid=2879#23263”> => Matches the page uid and content element. $pageAndAnchorMatches1 being 2879 and $pageAndAnchorMatches2 being 23263
  • Link to content element on page with L parameter: <a href=“t3://page?uid=2879&L=1#23260”> => Matches the page uid. $pageAndAnchorMatches1 being 2879. No match to the content element reference. $pageAndAnchorMatches2 is empty

The expected behavior would be for the match to find a integer after uid and a integer after the hash and ignore other parameter not relevant for the parsing

External links
Somewhat related to the b13/link2language PR here: https://github.com/b13/link2language/pull/26

Reviews 3

Files 3

History 510

  1. Soren Malling commented 01/21/25, 13:01

    Asking ChatGPT for a helping hand to build a pattern “we” came up with this

    https://regex101.com/r/MI3YOX/1

    Pattern:

    /page\?[^#]*\buid=(\d+)(?:[^#]*#(\d+))?/

    Testcases:

    t3://page?uid=2879&amp;L=1#23260
    t3://page?uid=2879#23263
    t3://page?uid=2881&amp;L=0

    Returned values per testcase:

    page?uid=2879&amp;L=1#23260
    2879
    23260
    
    page?uid=2879#23263
    2879
    23263
    
    page?uid=2881
    2881
  2. Soren Malling commented and changed attached Screenshot 2025-01-21 at 14.02.57.png 01/21/25, 13:04

    Screenshot shows the linkvalidator accepting the link despite extra parameters and finding the deleted content element

  3. Gerrit Code Review pushed patch set 1 for main to change 87838 status New Under Review 01/21/25, 13:33

  4. Gerrit Code Review pushed patch set 2 for main to change 87838 02/07/25, 22:07

  5. Gerrit Code Review pushed patch set 1 for 13.4 to change 88107 02/08/25, 22:53

  6. Soren Malling commented and changed status Under Review Resolved done 0 % 100 % 02/08/25, 22:55

    Applied in changeset commit:ca666001381708af4c69ce1b0c26ec6e7013ad50.

  7. Gerrit Code Review pushed patch set 1 for 12.4 to change 88329 status Resolved Under Review 02/24/25, 09:57

  8. Gerrit Code Review pushed patch set 2 for 12.4 to change 88329 02/24/25, 10:15

  9. Soren Malling commented and changed status Under Review Resolved 03/19/25, 07:40

    Applied in changeset commit:7c7ea7d3a7df108f50f71300db3682ced5d36b7f.

  10. Benni Mack changed status Resolved Closed 12/02/25, 14:26