#105989Extbase-based backend modules for f:be.tableList have no localized "Cancel" button
Description
The Fluid ViewHelper f:be.tableList uses the sysext/backend/Classes/RecordList/DatabaseRecordList.php
method makeControl to render a “Delete” button inside record lists.
Clicking on that link uses Build/Sources/TypeScript/backend/ajax-data-handler.ts which localizes
the modal popup contents with either the strings of anchorElement.dataset.buttonCloseText
or TYPO3.lang['button.cancel'] as a fallback.
In the extbase-based backend module, that TYPO3.lang fallback index is not available/set,
and returns a JavaScript error:
VM7262 ajax-data-handler.js:13 Uncaught TypeError: Cannot read properties of undefined (reading 'button.cancel')
at HTMLButtonElement.<anonymous> (VM7262 ajax-data-handler.js:13:1730)
at HTMLDocument.<anonymous> (VM7215 regular-event.js:13:433)
To fix this, the makeControl() method now also utilizes not only
@data-button-ok-text@ but also data-button-close-text so that the reliance on
@TYPO3.lang@ no longer is required.
All other methods in the TYPO3 core that set data-button-ok-text always
also populate that data attribute, so this patch streamlines this
bevhaviour.
Reviews 3
History 312
-
Gerrit Code Review pushed patch set 1 for main to change 87883 status
NewUnder Review <span data-processor="relativetime" data-value="2025-01-25T20:24:59+00:00" > 01/25/25, 20:24 </span> -
Gerrit Code Review pushed patch set 2 for main to change 87883 <span data-processor="relativetime" data-value="2025-01-26T11:19:02+00:00" > 01/26/25, 11:19 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 87883 <span data-processor="relativetime" data-value="2025-01-27T10:55:33+00:00" > 01/27/25, 10:55 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 87883 <span data-processor="relativetime" data-value="2025-01-27T11:01:39+00:00" > 01/27/25, 11:01 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 87953 <span data-processor="relativetime" data-value="2025-01-31T10:44:36+00:00" > 01/31/25, 10:44 </span>
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 87954 <span data-processor="relativetime" data-value="2025-01-31T10:45:38+00:00" > 01/31/25, 10:45 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 87883 <span data-processor="relativetime" data-value="2025-01-31T12:00:32+00:00" > 01/31/25, 12:00 </span>
-
Gerrit Code Review pushed patch set 2 for 13.4 to change 87953 <span data-processor="relativetime" data-value="2025-01-31T12:02:07+00:00" > 01/31/25, 12:02 </span>
-
Gerrit Code Review pushed patch set 2 for 12.4 to change 87954 <span data-processor="relativetime" data-value="2025-01-31T12:04:14+00:00" > 01/31/25, 12:04 </span>
-
Garvin Hicking commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-02-11T13:00:10+00:00" > 02/11/25, 13:00 </span> -
Andreas Kienast changed Duplicated by #106301 <span data-processor="relativetime" data-value="2025-03-04T13:06:34+00:00" > 03/04/25, 13:06 </span>
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-08-12T14:36:32+00:00" > 08/12/25, 14:36 </span>
Applied in changeset commit:42f112adee1017ed3124186cd7f0bc438a630a01.