#106329ImageProcessingInstructions misses an integer casting for one scenario
Description
$options['minHeight'] is missing an integer casting in this evaluation:
if (!empty($options['minHeight'])) {
if ($height < $options['minHeight'] || ($height === 0 && $cropArea->getHeight() < $options['minHeight'])) {
$height = $options['minHeight'];
$width = max(1, (int)round($cropArea->getWidth() * ($height / $cropArea->getHeight())));
}
}Reviews 2
Related issues 2
History 35
-
Garvin Hicking changed due date start date Follows #106169 Follows #106094 <span data-processor="relativetime" data-value="2025-03-07T08:06:24+00:00" > 03/07/25, 08:06 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 88522 status
NewUnder Review <span data-processor="relativetime" data-value="2025-03-07T08:06:37+00:00" > 03/07/25, 08:06 </span> -
Gerrit Code Review pushed patch set 1 for 13.4 to change 88523 <span data-processor="relativetime" data-value="2025-03-07T08:12:32+00:00" > 03/07/25, 08:12 </span>
-
Garvin Hicking commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-03-07T08:25:08+00:00" > 03/07/25, 08:25 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-08-12T14:36:34+00:00" > 08/12/25, 14:36 </span>
Applied in changeset commit:965b5e098fa029fcdd7efa1d1e83bc22e3d36ebe.