Issue Bug Closed

#106376Extension Manager: Function xml_set_object() is deprecated since 8.4

Markus Klein 03/17/25, 18:26 updated 12/02/25, 14:22

Description

in sysext/extensionmanager/Classes/Parser/ExtensionXmlParser.php line 85

Reviews 3

History 49

  1. Markus Klein commented 03/17/25, 18:31

    Removing the line already solves the problem with PHP 8.4. Obviously this is not needed anymore.
    Did not test with lower versions

  2. Garvin Hicking commented and changed status New Accepted 03/17/25, 19:44

    The callable syntax with [$this, 'methodName'] makes xml_set_object superfluous; it seems this is supported in all PHP version of 8.0.0 and above, probably even since 5.3: https://externals.io/message/123816

    So:
    Yes, I agree we could remove this for 13.4&main

  3. Gerrit Code Review pushed patch set 1 for main to change 88636 status Accepted Under Review 03/18/25, 07:56

  4. Gerrit Code Review pushed patch set 2 for main to change 88636 03/18/25, 10:04

  5. Gerrit Code Review pushed patch set 3 for main to change 88636 03/19/25, 09:03

  6. Gerrit Code Review pushed patch set 1 for 13.4 to change 88710 03/24/25, 20:05

  7. Gerrit Code Review pushed patch set 1 for 12.4 to change 88711 03/24/25, 20:06

  8. Garvin Hicking commented and changed status Under Review Resolved done 0 % 100 % 03/24/25, 20:10

    Applied in changeset commit:7e3a3a9f348f724351b10202ba01cb38edb25794.

  9. Benni Mack changed status Resolved Closed 12/02/25, 14:22