#106418"Copy Link" is coupled to the "Bookmark" feature, which is neither documented nor intuitive.
Description
The whole Share dropdown button (including bookmark creation and “copy link”) is only shown if the the current BE user mayMakeShortCut() which in turn checks TSconfig settings enableBookmarks and mayNotCreateEditBookmarks
Bookmarks and link sharing are two different things, even though they are shown in the same dropdown menu. The actual share link (“copy URL”) should either have separate enable settings or always be shown, since it has nothing to do with bookmarks. We just had to debug the core code to find this out the hard way, because the whole button was missing, because Bookmarks where disabled on purpose in that setup (but share links should not be disabled).
While it is is possible to get the behaviour with
options {
enableBookmarks = 1
mayNotCreateEditBookmarks = 0
}
it is neither documented nor intuitive that the bookmark settings implicitly have the side-effect of influencing the Share/“copy link” behaviour as well.
https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/UserTsconfig/Options.html#confval-useroptions-enablebookmarks
https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/UserTsconfig/Options.html#confval-useroptions-maynotcreateeditbookmarks
Reviews 2
History 711
-
S P changed description 03/24/25, 10:27
-
Garvin Hicking commented and changed status
NewNeeds Feedback 03/24/25, 14:36 -
S P commented 03/24/25, 15:34
Garvin Hicking wrote in #note-2:
> …what is the reason for needing to remove the bookmark functionality?Where do you read something about removal of the bookmakrs? The bookmarks are totally unaffected here. The report is about decoupling the “copy url” and the “create bookmark” button, which both currently are behind the same TSconfig setting. Currently the TSconfig bookmark settings do not only affect the bookmark feature but also the “copy url” feature: disabling boomarks via TSconfig currently also disables the “copy url” button (which does not has anything to do with “creating a bookmark”).
This is neither documented nor intuitive. So the suggest here is to either always show the “copy url” link or to provide a new setting for it to allow more fine-grained controlling. -
Garvin Hicking commented and changed status
Needs FeedbackNew 03/24/25, 15:53“because Bookmarks where disabled on purpose in that setup”
-
S P commented 03/24/25, 16:55
Garvin Hicking wrote in #note-4:
> “because Bookmarks where disabled on purpose in that setup”Yes, by the mentioned TSconfig bookmark setting. This bookmark setting exists, is not deprecated and is documented and is public API. So it can be used. Why does it matter why this setting is used by us? (because it was probably a customer requirement)
The report here is that this setting has the un-documented, un-intuitive, un-expected side-effect of also dis-/enabling the “copy link” (BE deep-link) feature. This is the report. No more, no less. -
Gerrit Code Review pushed patch set 1 for main to change 88738 status
NewUnder Review 03/25/25, 12:30 -
Gerrit Code Review pushed patch set 2 for main to change 88738 03/25/25, 12:51
-
Gerrit Code Review pushed patch set 3 for main to change 88738 03/25/25, 13:27
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 88818 03/28/25, 07:30
-
Benni Mack commented and changed status
Under ReviewResolved done0 %100 % 03/28/25, 08:05Applied in changeset commit:b50c2cf629a319db005dfbe48ff9b74ba7d6762e.
-
Benni Mack changed status
ResolvedClosed 12/02/25, 14:21
Thanks for the report. To understand the use case better – what is the reason for needing to remove the bookmark functionality?