Issue Task Closed

#106491Mitigate phpstan issue with `doctrine/dbal 4.3.x`

Stefan Bürk 04/02/25, 10:33 updated 12/02/25, 14:22

Description

Upcoming `doctrine/dbal 4.3.x` adds additional PHP DocBlocks
to narrow down array shapes and would be catched up by our
nightlies when the version is released.

`TYPO3\CMS\Core\Tests\Functional\Database\Schema\SchemaMigratorTest`
contains checks on the array representation of a `Column` explicitly
testing for the existance of the `default` key in the array, which
is already ensured since `doctrine/dbal 4.0.0`. Not providing any
value to be tested, array key checks are removed or replaced as small
early mitigation and preventing of failing nightly when the new version
is released.

Reviews 2

History 26

  1. Gerrit Code Review pushed patch set 1 for main to change 88909 status New Under Review 04/02/25, 10:48

  2. Gerrit Code Review pushed patch set 2 for main to change 88909 04/02/25, 10:49

  3. Gerrit Code Review pushed patch set 3 for main to change 88909 04/02/25, 10:55

  4. Gerrit Code Review pushed patch set 1 for 13.4 to change 88915 04/02/25, 11:43

  5. Stefan Bürk commented and changed status Under Review Resolved done 0 % 100 % 04/02/25, 11:55

    Applied in changeset commit:78239d56793fc2c83eea6ba6531741f65961ce20.

  6. Benni Mack changed status Resolved Closed 12/02/25, 14:22