Issue Bug Closed

#106621Make LoggerInterface injectable via methodInjections

Lina Wolf 04/25/25, 15:03 updated 08/11/26, 08:46

Description

In https://review.typo3.org/c/Packages/TYPO3.CMS/+/89080, patchset 4 I tried to inject the LoggerInterface into the ActionController. Doing so failed all tests.

All over EXT:extbase a logger is only used in one place and there it is currently created via GU::makeInstance, it was introduced with https://github.com/typo3/typo3/commit/46cc4bcc71d5615878e19698505a8736bbb76f5c

Theoretically the LoggerAwareInterface (https://docs.typo3.org/permalink/changelog:feature-82441) could be used to inject a Logger via setLogger(), however using that interface is discouraged.

Reviews 3

History 722

  1. Stefan Bürk commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-04-19T15:15:09+00:00" > 04/19/26, 15:15 </span>

    Applied in changeset commit:a96a81f22f40ba64d5e2441e3208b5c1f4b3549c.

  2. Gerrit Code Review pushed patch set 1 for 13.4 to change 94991 status Closed Under Review <span data-processor="relativetime" data-value="2026-07-29T14:02:16+00:00" > 07/29/26, 14:02 </span>

  3. Stefan Bürk commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2026-07-29T14:20:09+00:00" > 07/29/26, 14:20 </span>

    Applied in changeset commit:d686115dcdb44d7e1f8c56d23df9c5821b4e227a.