Issue Task Rejected

#106884Cleanup password hashing classes

Torben Hansen 06/14/25, 10:48 updated 06/23/25, 20:07

Description

- Functions in classes have many duplicate descriptions derived from an interface
- Functions haw superfluous type annotations (doc comment and php native type)
- Some properties are not typed
- Add #[\SensitiveParameter] for clear text password arguments
- Remove MD5 password hashing class
- Declare Phpass, Blowfish, Pbkdf2 and Phpass as legacy
- Move shared functions of legacy password hashing classed to abstract class
- Declare classes as final

Reviews 1

History 35

  1. Torben Hansen changed description 06/14/25, 10:49

  2. Torben Hansen changed description 06/14/25, 10:51

  3. Gerrit Code Review pushed patch set 1 for main to change 89731 status New Under Review 06/14/25, 11:04

  4. Gerrit Code Review pushed patch set 2 for main to change 89731 06/23/25, 16:14

  5. Torben Hansen changed status Under Review Rejected 06/23/25, 20:07