Issue Bug Closed

#107015redirects:cleanup didn't behave correctly

Paul Kamma 07/01/25, 15:00 updated 03/31/26, 09:00

Description

I’ve notices 1 odd and 1 missing implementation in the redirects:cleanup Task.

1. ‘days’ Option
Inside the TYPO3\CMS\Redirects\Repository\Demand Method fromCommandInput on line 126 we have this construct

$input->getOption('days')
                ? new \DateTimeImmutable($input->getOption('days') . ' days ago')
                : new \DateTimeImmutable('90 days ago'),

The Problem here is that it’s not possible to create task which ignore the days option. When I uncheck it or set 0 it always create the default 90 days.
Or is the 90 days somewhore documented as default?

2. integrity_status

Inside the TYPO3\CMS\Redirects\Repository\RedirectRepostory removeByDemand Method this whole part is missing at the end:

        if ($demand->hasIntegrityStatus()) {
            $queryBuilder->andWhere(
                $queryBuilder->expr()->eq('integrity_status', $queryBuilder->createNamedParameter($demand->getIntegrityStatus(), Connection::PARAM_STR))
            );
        }

so currenty the integrity_status isn’t included in the delete query.

Reviews 2

History 24

  1. Gerrit Code Review pushed patch set 1 for main to change 93156 status New Under Review 03/12/26, 07:33

  2. Gerrit Code Review pushed patch set 1 for 13.4 to change 93173 03/13/26, 04:40

  3. Peter Kraume commented and changed status Under Review Resolved done 0 % 100 % 03/13/26, 04:45

    Applied in changeset commit:b26f6ad552b38e94fae8feb7aa753d0d132b5875.

  4. Benni Mack changed status Resolved Closed 03/31/26, 09:00