Issue Bug Closed

#107089Warn on resetting install tool password via console command when overridden

Lina Wolf 07/14/25, 08:24 updated 03/31/26, 09:00

Description

when the install tool password is overridden in the config/system/additional.php
it cannot be changed with the newly introduced command `typo3 install:password:set`.

We should warn about the fact so as not to confuse new Integrators / Administrators.

Reviews 1

History 924

  1. Garvin Hicking commented and changed status New Needs Feedback <span data-processor="relativetime" data-value="2025-07-14T08:31:08+00:00" > 07/14/25, 08:31 </span>

    Do you have a proposal how to achieve this? Sounds a bit complicated because it would require a follow-uo request and a new bootstrap with backend context tk see if the password takes effect.

    IMO if an admin overrides this setting they should be aware of theor individual aettings overrriding this.

    We could add a disclaimer in the help output of the command?

  2. Benjamin Franzke commented and changed status Needs Feedback Accepted <span data-processor="relativetime" data-value="2025-07-14T09:05:48+00:00" > 07/14/25, 09:05 </span>

    Garvin Hicking wrote in #note-1:
    > Do you have a proposal how to achieve this? Sounds a bit complicated because it would require a follow-uo request and a new bootstrap with backend context tk see if the password takes effect.

    Load a non-overwritten configuration via ConfigurationManager->getMergedLocalConfiguration() (does not load additional.php) and compare that to the current value as in https://github.com/TYPO3/typo3/blob/4929400759e583fad5ad6556a600e5ea5c240cba/typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php#L113

    This could be done preemptive, before attempting to change the value.

    I would not do a post-save check, as it’s complicated as you mentioned.
    A warning that is printed before asking for the new password should be sufficient.

  3. Garvin Hicking commented <span data-processor="relativetime" data-value="2025-07-14T14:22:30+00:00" > 07/14/25, 14:22 </span>

    Note to self: This comparison might not catch setups where a settings.php and additional.php both contain the same installToolPassword hash. In this case the strings would be identical, but changing it in settings.php would not take effect.

    Not sure how to detect such a setup, so I would say: Add a disclaimer about this, and do the “value is different” check as suggested, because it improves situations where we CAN detect differences.

  4. Gerrit Code Review pushed patch set 8 for main to change 90099 status Accepted Under Review <span data-processor="relativetime" data-value="2025-07-21T09:36:11+00:00" > 07/21/25, 09:36 </span>

  5. Garvin Hicking commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-01-14T10:20:10+00:00" > 01/14/26, 10:20 </span>

    Applied in changeset commit:8cc147f7b0ae3189427ab6a9a17bcd176c1aeea4.