Issue Task Closed

#107300Replace deprecated `SplObjectStorage` method calls

Stefan Bürk 08/16/25, 12:50 updated 12/02/25, 13:58

Description

PHP8.5.0beta1 deprecated following `SplObjectStorage` methods:

  • `SplObjectStorage::contains()` => `SplObjectStorage::offsetExists()`
  • `SplObjectStorage::attach()` => `SplObjectStorage::offsetSet()`
  • `SplObjectStorage::detach() => `SplObjectStorage::offsetUnset()`

[1] https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_splobjectstoragecontains_splobjectstorageattach_and_splobjectstoragedetach
2 https://github.com/php/php-src/blob/5f477d9457de1d78536961fa5679b638102b6631/UPGRADING#L410-L414

Reviews 3

History 212

  1. Gerrit Code Review pushed patch set 1 for main to change 90417 status New Under Review 08/16/25, 12:52

  2. Gerrit Code Review pushed patch set 1 for 13.4 to change 90418 08/16/25, 12:59

  3. Gerrit Code Review pushed patch set 2 for main to change 90417 08/16/25, 12:59

  4. Gerrit Code Review pushed patch set 2 for 13.4 to change 90418 08/16/25, 13:01

  5. Gerrit Code Review pushed patch set 3 for main to change 90417 08/16/25, 13:02

  6. Gerrit Code Review pushed patch set 1 for 12.4 to change 90419 08/16/25, 13:07

  7. Gerrit Code Review pushed patch set 2 for 12.4 to change 90419 08/16/25, 13:07

  8. Gerrit Code Review pushed patch set 4 for main to change 90417 09/02/25, 12:43

  9. Gerrit Code Review pushed patch set 3 for 12.4 to change 90419 09/02/25, 12:47

  10. Gerrit Code Review pushed patch set 3 for 13.4 to change 90418 09/02/25, 12:47

  11. Stefan Bürk commented and changed status Under Review Resolved done 0 % 100 % 09/02/25, 15:40

    Applied in changeset commit:cbd02b1f83c0559d295fb9f46f357f377fd77808.

  12. Benni Mack changed status Resolved Closed 12/02/25, 13:58