Issue Bug Closed

#107305Commit message check: The maximum line length of 72 characters is exceeded.

Christian Weiske 08/18/25, 05:58 updated 08/18/25, 12:57

Description

When creating a TYPO3 core patch, I always get the error message:

> The maximum line length of 72 characters is exceeded.

This is because the git commit message comments are validated as well – and in the German translation, the comments are longer than 72 characters.
When removing the git message comments, I get no error by the commit message validator.

; Bitte geben Sie eine Commit-Beschreibung für Ihre Änderungen ein. Zeilen,
; die mit ';' beginnen, werden ignoriert, und eine leere Beschreibung
; bricht den Commit ab.
;
; Datum:            Mon Aug 18 07:53:02 2025 +0200
;
; Auf Branch tca-migration-flexform-items-string
; Zum Commit vorgemerkte Änderungen:
;   geändert:       typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php
;   geändert:       typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php
;

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.

History 4

  1. Garvin Hicking commented and changed status New Needs Feedback 08/18/25, 08:33

    Which git version/config are you usinf here? I’ve ever only seen “#” as the delimiter for comments , thats what the commit parsers evaluatues…?

    I think this is more a config issue and would recommend to use the much more broader used # syntax before we adapt the commit check and introduce possible edge cases….?

  2. Christian Weiske commented 08/18/25, 08:36

    I’m using 2.39.5 and I indeed have a different comment character in my user-wide git config:

    [core]
            commentChar = ";"

    I have no idea why it is in there and will remove it.

    This ticket can be closed.

  3. Christian Weiske commented 08/18/25, 08:37

    It probably was because in some projects we start the commit message with the #bugnumber, and using # as comment character breaks with that.

  4. Garvin Hicking commented and changed status Needs Feedback Closed 08/18/25, 12:57

    Ok great – yeah for maximized compatibility better use the hashtag; in your project you could set it on that project level – closing as suggested :)