#107360Regression: DataHandler processCmdMap hook subscribers accepting arguments by reference broken by inline type cast of function arguments
Description
Introduced in https://github.com/TYPO3/typo3/commit/c6f30d00c48a0cd2fdd92a9fcfe478ce6aabb5ed which adds unnecessary and unrelated type casts of function arguments, which broke every extension and project that has a DataHandler hook subscriber which takes any of the affected arguments as pass by reference; something that has worked problem-free for at least 10 years. This change got picked to the 13.4 branch, in a bugfix version, and has existed in multiple subsequent bugfix versions (.15 to .17, and still not pending in 13.4 branch) since then.
The regression was since then fixed in the main branch by a patch that changed these lines back in an also unrelated change: https://github.com/TYPO3/typo3/commit/c5b387944bc29952dbac12a721cc0e9fe9fbeaf9 but that was never backported to the 13.4 branch like the original change.
Reviews 1
Related issues 1
History 45
-
Garvin Hicking changed Related to #106959 <span data-processor="relativetime" data-value="2025-08-30T11:52:39+00:00" > 08/30/25, 11:52 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 90527 status
NewUnder Review <span data-processor="relativetime" data-value="2025-09-01T07:27:54+00:00" > 09/01/25, 07:27 </span> -
Benni Mack commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-09-01T19:55:11+00:00" > 09/01/25, 19:55 </span>Applied in changeset commit:0659f350d1f7c6be36288c27f66021446a64d003.
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T13:58:20+00:00" > 12/02/25, 13:58 </span>
Any hook subscriber method that looks along these lines, taking any of the three first arguments by reference, is affected:
public function processCmdmap_postProcess( &$command, &$table, &$id, // ... ) {