#107414Regression in GeneralUtility::sanitizeLocalUrl
Description
With TYPO 12.4.37 and and 13.4.18 – searching for items with spaces and edit + close results in that the user
ends up on the root page instead of staying in the corresponding module.
Example:
Go to List module and choose root page Search for page title with space in it Edit page press "Close" You end up in on the root page instead of "staying" in the module like in 12.4.36
The “close” button url looks like and seems properly encoded
the return url looks identical in 12.4.36 and 12.4.37.
Since the check operates on the decoded url it will always fail if the parameters contains
spaces:
$decodedUrl = rawurldecode($url);
if (strpbrk($decodedUrl, " \n\r\t\v\x00") !== false) {
static::getLogger()->notice('URL "{url}" contains unexpected whitespace and was denied as local url.', ['url' => $url]);
return '';
}
I’m uncertain if the check should be on the original url instead of the decoded – newer the less the bug prevents us from upgrading to 12.4.37 since it breaks the edit functionality for standard backend core modules and own backend modules.
Reviews 3
History 713
-
Thomas Hohn changed description <span data-processor="relativetime" data-value="2025-09-09T11:22:29+00:00" > 09/09/25, 11:22 </span>
-
Thomas Hohn changed description <span data-processor="relativetime" data-value="2025-09-09T11:23:01+00:00" > 09/09/25, 11:23 </span>
-
Thomas Hohn changed description <span data-processor="relativetime" data-value="2025-09-09T11:23:23+00:00" > 09/09/25, 11:23 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 90645 status
NewUnder Review <span data-processor="relativetime" data-value="2025-09-09T15:07:04+00:00" > 09/09/25, 15:07 </span> -
Gerrit Code Review pushed patch set 2 for main to change 90645 <span data-processor="relativetime" data-value="2025-09-09T17:04:24+00:00" > 09/09/25, 17:04 </span>
-
Garvin Hicking changed Is Regression 1 <span data-processor="relativetime" data-value="2025-09-09T19:24:33+00:00" > 09/09/25, 19:24 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 90645 <span data-processor="relativetime" data-value="2025-09-10T09:12:54+00:00" > 09/10/25, 09:12 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 90687 <span data-processor="relativetime" data-value="2025-09-15T12:56:03+00:00" > 09/15/25, 12:56 </span>
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 90688 <span data-processor="relativetime" data-value="2025-09-15T12:56:19+00:00" > 09/15/25, 12:56 </span>
-
Gerrit Code Review pushed patch set 2 for 12.4 to change 90688 <span data-processor="relativetime" data-value="2025-09-15T12:57:43+00:00" > 09/15/25, 12:57 </span>
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-09-15T13:25:10+00:00" > 09/15/25, 13:25 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T13:04:23+00:00" > 12/02/25, 13:04 </span> -
Andreas Kienast changed Duplicated by #108728 <span data-processor="relativetime" data-value="2026-02-09T06:49:56+00:00" > 02/09/26, 06:49 </span>
Applied in changeset commit:d699f7144c8150e2c0b5415ecd572a8a17420f05.