Issue Task Closed

#107792Simplify RecoveryCodes::generatePlainRecoveryCodes

Oliver Hader 10/20/25, 11:51 updated 12/02/25, 12:04

Description

RecoveryCodes::generatePlainRecoveryCodes uses a randomly generated 64-bit word to generate random numeric recovery codes using `hexdec` with ignoring the maximum integer limit of `PHP_INT_MAX`, which is a 63-bit integer.

Reviews 3

History 39

  1. Gerrit Code Review pushed patch set 1 for main to change 91168 status New Under Review 10/20/25, 11:55

  2. Gerrit Code Review pushed patch set 2 for main to change 91168 10/20/25, 11:59

  3. Oliver Hader changed Related to #107748 10/20/25, 12:03

  4. Gerrit Code Review pushed patch set 3 for main to change 91168 10/20/25, 12:28

  5. Gerrit Code Review pushed patch set 4 for main to change 91168 10/20/25, 13:08

  6. Gerrit Code Review pushed patch set 1 for 13.4 to change 91186 10/21/25, 12:23

  7. Gerrit Code Review pushed patch set 1 for 12.4 to change 91187 10/21/25, 12:26

  8. Oliver Hader commented and changed status Under Review Resolved done 0 % 100 % 10/21/25, 13:50

    Applied in changeset commit:786d95bfe7da24f1345077685c60ec836b1a8281.

  9. Benni Mack changed status Resolved Closed 12/02/25, 12:04