#107820ResourceCompressor does not handle false return value from GeneralUtility::getUrl() when fetching external resources
Description
When the TYPO3 Core’s ResourceCompressor retrieves external resources (for example, remote JavaScript or CSS files), it calls
GeneralUtility::getUrl($url) to fetch their content.
However, getUrl() can return false if the request fails (for example, due to a timeout, 404 response, or network issue).
Currently, ResourceCompressor::retrieveExternalFile() does not check whether $externalContent is a boolean before attempting to compute MD5 hashes and write the file to disk.
This can lead to PHP warnings such as:
md5() expects parameter 1 to be string, bool given
or to the creation of an invalid (empty) cache file.
Steps to Reproduce:
- Configure TYPO3 to include an external resource (for instance, a CSS file hosted on an unreachable URL).
- Clear the TYPO3 cache to force re-generation of compressed resources.
- Observe the PHP error log or TYPO3 logs.
Expected behavior:
TYPO3 should detect that the resource could not be fetched and handle the error gracefully (log a warning, skip writing the file).
Actual behavior:
The Core tries to compute md5($externalContent) even when $externalContent is false, leading to PHP warnings and possibly empty or corrupted cache files.
Reviews 1
Related issues 1
History 421
-
Patrick Gaumond changed description <span data-processor="relativetime" data-value="2025-10-27T14:53:02+00:00" > 10/27/25, 14:53 </span>
-
Christian Kuhn changed Related to #108055 <span data-processor="relativetime" data-value="2025-11-11T16:05:22+00:00" > 11/11/25, 16:05 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 91562 status
NewUnder Review <span data-processor="relativetime" data-value="2025-11-11T16:56:44+00:00" > 11/11/25, 16:56 </span> -
Gerrit Code Review pushed patch set 2 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T08:59:24+00:00" > 11/12/25, 08:59 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T10:16:30+00:00" > 11/12/25, 10:16 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T10:19:35+00:00" > 11/12/25, 10:19 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T10:32:18+00:00" > 11/12/25, 10:32 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T10:38:36+00:00" > 11/12/25, 10:38 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T10:51:00+00:00" > 11/12/25, 10:51 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T10:58:43+00:00" > 11/12/25, 10:58 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T11:23:02+00:00" > 11/12/25, 11:23 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T12:57:20+00:00" > 11/12/25, 12:57 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T13:08:36+00:00" > 11/12/25, 13:08 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T13:31:02+00:00" > 11/12/25, 13:31 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T14:01:23+00:00" > 11/12/25, 14:01 </span>
-
Gerrit Code Review pushed patch set 14 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T14:07:35+00:00" > 11/12/25, 14:07 </span>
-
Gerrit Code Review pushed patch set 15 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T14:16:50+00:00" > 11/12/25, 14:16 </span>
-
Gerrit Code Review pushed patch set 16 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T14:44:13+00:00" > 11/12/25, 14:44 </span>
-
Gerrit Code Review pushed patch set 17 for main to change 91562 <span data-processor="relativetime" data-value="2025-11-12T14:50:53+00:00" > 11/12/25, 14:50 </span>
-
Christian Kuhn commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-11-13T10:15:08+00:00" > 11/13/25, 10:15 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T12:04:37+00:00" > 12/02/25, 12:04 </span>
Applied in changeset commit:d8acfda81605ca802e829e03bf9189bc27feea33.