#107827ESC key does not close dialogs in some cases
Description
This error was introduced by the new dialog handling in commit 979453369c3 (#107443).
Probably the ESC key handling is a bit different.
Reproduction steps
Occurence 1
- Open “Search” Dialog
- Use tab key to focus the Filter button
clipboard-202510241117-pmqvw.png - Press
ESCkey
Occurence 2
- Go to the “Edit page” Mode
- Navigate to the “Resources” Tab and activate the “Create new relation” Button
clipboard-202510241119-67euy.png - Focus any element apart from the close button
clipboard-202510241120-eqrsz.png - Press
ESCkey
Impact
Prevents closing open Dialogs using the ESC key depending on focused element
Target group
Keyboard user
Definition of Done
I OPEN a dialog
I focus an element inside the dialog
I can CLOSE the dialog using ESC key
Reviews 1
Related issues 2
Files 3
History 518
-
Michael Telgkamp changed Related to #107443 <span data-processor="relativetime" data-value="2025-10-24T09:26:55+00:00" > 10/24/25, 09:26 </span>
-
Michael Telgkamp changed Related to #107829 <span data-processor="relativetime" data-value="2025-10-24T09:35:33+00:00" > 10/24/25, 09:35 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 91259 status
NewUnder Review <span data-processor="relativetime" data-value="2025-10-26T20:33:38+00:00" > 10/26/25, 20:33 </span> -
Gerrit Code Review pushed patch set 2 for main to change 91259 <span data-processor="relativetime" data-value="2025-10-26T20:54:16+00:00" > 10/26/25, 20:54 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 91259 <span data-processor="relativetime" data-value="2025-10-26T21:38:13+00:00" > 10/26/25, 21:38 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 91259 <span data-processor="relativetime" data-value="2025-10-26T22:20:14+00:00" > 10/26/25, 22:20 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 91259 <span data-processor="relativetime" data-value="2025-10-27T05:39:19+00:00" > 10/27/25, 05:39 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 91259 <span data-processor="relativetime" data-value="2025-10-27T06:02:25+00:00" > 10/27/25, 06:02 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 91259 <span data-processor="relativetime" data-value="2025-10-27T11:52:38+00:00" > 10/27/25, 11:52 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 91259 <span data-processor="relativetime" data-value="2025-10-28T12:13:53+00:00" > 10/28/25, 12:13 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 91259 <span data-processor="relativetime" data-value="2025-10-28T12:17:30+00:00" > 10/28/25, 12:17 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 91259 <span data-processor="relativetime" data-value="2025-11-20T05:11:11+00:00" > 11/20/25, 05:11 </span>
-
Oliver Hader changed target version <span data-processor="relativetime" data-value="2026-01-23T12:29:51+00:00" > 01/23/26, 12:29 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 91259 <span data-processor="relativetime" data-value="2026-01-25T00:19:06+00:00" > 01/25/26, 00:19 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 91259 <span data-processor="relativetime" data-value="2026-01-28T17:05:49+00:00" > 01/28/26, 17:05 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 91259 <span data-processor="relativetime" data-value="2026-01-30T09:54:26+00:00" > 01/30/26, 09:54 </span>
-
Benjamin Franzke commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-01-30T14:55:08+00:00" > 01/30/26, 14:55 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2026-03-31T09:00:47+00:00" > 03/31/26, 09:00 </span>
Applied in changeset commit:9f50475fb3b36b907159c1eb7396165b069aab4f.