#108284Avoid breaking change in DocHeaderComponent
Description
With #107875 a change was made that affected the Module submenu selector to require a label for the DropDownButton.
However, existing modules might have created a docheader like this:
$menu = $moduleTemplate->getDocHeaderComponent()->getMenuRegistry()->makeMenu();
$menu->setIdentifier('cruPsr14EventList');
$menuItems = [
'index' => [
'controller' => 'Module',
'action' => 'index',
'route' => 'tx_psr14_event_list_index',
'label' => "Index",
],
'list' => [
'controller' => 'Module',
'action' => 'listCoreEventsAction',
'route' => 'tx_psr14_event_list_list',
'label' => "List",
]
];
$uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
foreach ($menuItems as $menuItemConfig) {
$currentUri = $request->getUri();
$action = $menuItemConfig['route'];
$uri = $uriBuilder->buildUriFromRoute($action, [$request]);
$isActive = ($currentUri === $uri);
$menuItem = $menu->makeMenuItem()
->setTitle($menuItemConfig['label'])
->setHref((string)$uri)
->setActive($isActive);
$menu->addMenuItem($menuItem);
}
$moduleTemplate->getDocHeaderComponent()->getMenuRegistry()->addMenu($menu);
This was fine in v12+v13, but breaks in v13 because no `$menu->setLabel(…)` call was required before.
To fix this, a specific label could be set.
Reviews 1
Related issues 1
History 39
-
Garvin Hicking changed Related to #107875 <span data-processor="relativetime" data-value="2025-11-24T08:21:59+00:00" > 11/24/25, 08:21 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 91843 status
NewUnder Review <span data-processor="relativetime" data-value="2025-11-24T08:24:08+00:00" > 11/24/25, 08:24 </span> -
Gerrit Code Review pushed patch set 2 for main to change 91843 <span data-processor="relativetime" data-value="2025-11-24T08:45:14+00:00" > 11/24/25, 08:45 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 91843 <span data-processor="relativetime" data-value="2025-11-24T11:13:38+00:00" > 11/24/25, 11:13 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 91843 <span data-processor="relativetime" data-value="2025-11-24T11:14:45+00:00" > 11/24/25, 11:14 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 91843 <span data-processor="relativetime" data-value="2025-11-24T11:59:52+00:00" > 11/24/25, 11:59 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 91843 <span data-processor="relativetime" data-value="2025-11-24T12:02:20+00:00" > 11/24/25, 12:02 </span>
-
Garvin Hicking commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-11-24T14:40:07+00:00" > 11/24/25, 14:40 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T11:48:32+00:00" > 12/02/25, 11:48 </span>
Applied in changeset commit:d08b28cbc4e13ecd0fe9a39ea7824e062885ee4f.