Issue Bug Closed

#10831New preview window shows wrong behavior for new page in LIVE WS

Francois Suter 11/16/10, 12:18 updated 08/11/26, 08:46

Description

Having tested RFC #13610 pending in the core list, I was able to play with the new workspace preview. I found the following problem: assume that you have created a new page and are previewing it. The LIVE tab/frame used to show an (error) message in the previous versions of TYPO3:

“New page! The previewed page is created in the workspace and has no counterpart in the live workspace.”

This does not happen anymore. Instead we get a TYPO3 error about a broken rootline (which is correct in principle, but far less informative than the message that appeared before). This feature should not be lost.

Reviews 2

Files 2

History 1318

  1. Tolleiv Nietsch commented and changed status New Accepted 11/18/10, 18:25

    Absolutely right thanks for bringing that up

  2. Steffen Ritter changed target version 11/18/10, 22:36

  3. Tolleiv Nietsch changed assigned to Tolleiv Nietsch 11/22/10, 18:38

  4. Tolleiv Nietsch changed attached 10831.patch 11/24/10, 18:25

  5. Tolleiv Nietsch commented and changed done 0 % 90 % 11/24/10, 18:33

    pending as FYI48 in the typo3.team.workspaces newsgroup

  6. Tolleiv Nietsch changed status Accepted Under Review 11/24/10, 18:33

  7. Tolleiv Nietsch commented and changed attached 10831v2.patch status Under Review Resolved done 90 % 100 % 11/29/10, 18:10

    Committed to trunk (rev. 3105)

  8. Francois Suter commented 11/29/10, 20:36

    I’m sorry but that doesn’t work, because you forgot to pass the $language parameter in the call tx_Workspaces_Service_Workspaces::isNewPage() (in the PreviewController.php, line 95).

    BTW, there’s a typo in the same file, the line just above: “supposed” => “supported”

  9. Michael Stucki changed category 12/10/13, 01:11

  10. Michael Stucki changed project id category target version 12/10/13, 01:13

  11. Benni Mack changed status Resolved Closed 10/02/18, 12:38

  12. Gerrit Code Review pushed patch set 1 for main to change 95129 status Closed Under Review 08/06/26, 19:15

  13. Gerrit Code Review pushed patch set 2 for main to change 95129 08/06/26, 19:17

  14. Gerrit Code Review pushed patch set 3 for main to change 95129 08/06/26, 21:18

  15. Gerrit Code Review pushed patch set 4 for main to change 95129 08/06/26, 21:46

  16. Gerrit Code Review pushed patch set 1 for 14.3 to change 95155 08/06/26, 21:53

  17. Philip Kuban commented and changed status Under Review Resolved 08/06/26, 22:45

    Applied in changeset commit:83803c52f106513938fd4e0585851e385be2c795.

  18. Benni Mack changed status Resolved Closed 08/11/26, 08:46