#108413[BUGFIX] Extension Scanner matchers crash on dynamic method calls
Description
Problem
The Extension Scanner in the Install Tool crashes with a TypeError when scanning extensions that contain dynamic method calls like `$this->$methodName()` or `$object->$variable()`.
Environment
- TYPO3 Version: 14.1-dev (main branch)
- PHP Version: 8.2+
Affected Files
9 matcher classes are affected:- MethodArgumentDroppedMatcher
- MethodArgumentDroppedStaticMatcher
- MethodArgumentRequiredMatcher
- MethodArgumentRequiredStaticMatcher
- MethodArgumentUnusedMatcher
- MethodCallMatcher
- MethodCallStaticMatcher
- InterfaceMethodChangedMatcher
- PropertyExistsStaticMatcher
Root Cause
The matchers assume `$node->name` is always a `PhpParser\Node\Identifier` and access `$node->name->name` directly. When the method name is a variable (dynamic call), `$node->name` is a
`PhpParser\Node\Expr\Variable`, which has no `name` property.
Solution
Add an explicit type check using `$node->name instanceof Identifier` before accessing `$node->name->name`. This safely skips dynamic method calls that cannot be matched against deprecation patterns
anyway.
Impact
Without this fix, extensions using dynamic method calls cannot be scanned, preventing developers from identifying actual deprecations in their code.
Reviews 2
History 419
-
Sebastian Mendel changed TYPO3 Version
1314 PHP Version 8.2 <span data-processor="relativetime" data-value="2025-12-06T00:35:18+00:00" > 12/06/25, 00:35 </span> -
Sebastian Mendel changed description <span data-processor="relativetime" data-value="2025-12-06T00:35:52+00:00" > 12/06/25, 00:35 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 92020 status
NewUnder Review <span data-processor="relativetime" data-value="2025-12-06T00:45:13+00:00" > 12/06/25, 00:45 </span> -
Gerrit Code Review pushed patch set 2 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-06T00:48:49+00:00" > 12/06/25, 00:48 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-06T04:39:16+00:00" > 12/06/25, 04:39 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-06T08:52:46+00:00" > 12/06/25, 08:52 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-06T09:03:55+00:00" > 12/06/25, 09:03 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-06T11:18:57+00:00" > 12/06/25, 11:18 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-06T13:31:59+00:00" > 12/06/25, 13:31 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-06T13:36:35+00:00" > 12/06/25, 13:36 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-06T13:38:54+00:00" > 12/06/25, 13:38 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-08T11:24:58+00:00" > 12/08/25, 11:24 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-08T11:32:36+00:00" > 12/08/25, 11:32 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 92020 <span data-processor="relativetime" data-value="2025-12-08T18:27:20+00:00" > 12/08/25, 18:27 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 92020 <span data-processor="relativetime" data-value="2026-04-22T06:38:28+00:00" > 04/22/26, 06:38 </span>
-
Gerrit Code Review pushed patch set 14 for main to change 92020 <span data-processor="relativetime" data-value="2026-06-11T15:27:20+00:00" > 06/11/26, 15:27 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 94497 <span data-processor="relativetime" data-value="2026-06-11T16:12:38+00:00" > 06/11/26, 16:12 </span>
-
Sebastian Mendel commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-06-11T17:10:11+00:00" > 06/11/26, 17:10 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2026-08-11T08:46:42+00:00" > 08/11/26, 08:46 </span>
Applied in changeset commit:1e6ad9d9a7623ed07f76713ee6f1b6530dfd1b9b.