Issue Task Resolved

#108813Core IconForRecord ViewHelper should support RecordInterface

Nikita Hovratov 01/30/26, 13:38 updated 09/02/26, 17:15

Description

Right now this ViewHelper only works with raw arrays. But as we are now moving more and more towards Records it would be nice to add RecordInterface support.

Current workaround: <core:iconforrecord table="tt_content" row="{CType: item.CType}"></core:iconforrecord>
Desired: <core:iconforrecord table="{record.mainType}" row="{record}"></core:iconforrecord>

Reviews 2

History 712

  1. Nikita Hovratov changed subject Core IconForRecord should support RecordInterface Core IconForRecord ViewHelper should support RecordInterface 01/30/26, 13:38

  2. Garvin Hicking commented 01/30/26, 14:06

    Maybe use “record” then instead of “row” for distinction?

    Are you on this?

  3. Nikita Hovratov commented 01/30/26, 17:07

    Garvin Hicking wrote in #note-2:
    > Maybe use “record” then instead of “row” for distinction?

    Hm, unsure. In CObject VH we can put an array or RecordInterface into “data”. In the end Record holds the db row anyway, but we can’t access it in Fluid.
    For the user in Fluid it is easier not to guess if he has an array or Record at hand. Especially for integrators this distinction is confusing. So I would relax the parameter input strictness for the sake of fool-prove usage.

    > Are you on this?
    No, if you want you can tackle it :)

  4. Garvin Hicking commented and changed status New Accepted assigned to Garvin Hicking 01/30/26, 17:16

    Fair point. :)

    I’ll check this out, but it will take a couple of days. If anyone else reads this (…haha) go ahead, I’ll review ;)

  5. Benni Mack changed Sprint Focus On Location Sprint 08/06/26, 16:02

  6. Gerrit Code Review pushed patch set 1 for main to change 95461 status Accepted Under Review 08/27/26, 20:25

  7. Gerrit Code Review pushed patch set 2 for main to change 95461 08/27/26, 20:39

  8. Gerrit Code Review pushed patch set 3 for main to change 95461 09/02/26, 15:10

  9. Gerrit Code Review pushed patch set 1 for 14.3 to change 95570 09/02/26, 15:59

  10. Georg Ringer commented and changed status Under Review Resolved done 0 % 100 % 09/02/26, 16:10

    Applied in changeset commit:31c1887202ffa18defc49d2b328f0e62f7ebfcf5.

  11. Gerrit Code Review pushed patch set 2 for 14.3 to change 95570 status Resolved Under Review 09/02/26, 16:56

  12. Georg Ringer commented and changed status Under Review Resolved 09/02/26, 17:15

    Applied in changeset commit:f3d696bfc664256be7867e4b97d244fb9b610b0b.